Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool should be able to handle null column data and treat it as an empty array #81

Open
nthitz opened this issue Nov 9, 2017 · 1 comment

Comments

@nthitz
Copy link
Member

nthitz commented Nov 9, 2017

Currently the filter tool breaks if column data has metadata: null things break. This should be treated as metadata: [] and just treat the file as if columns have no metadata

@iimog
Copy link
Contributor

iimog commented Dec 4, 2017

I have a simple (but not perfect) fix in my pull request #67, see https://github.com/PitchInteractiveInc/Phinch/pull/67/files#diff-3283ec1d765c474b09e8714d4a319672R98
This fix only works if the metadata is null for the first row.
As you can check at https://blackbird.iimog.org the file from issue #82 loads without any problems there.

If you decide using the biojs-io-biom javascript library (disclosure: I am an author of this library) as is also part of my pull request #67 this conversion could also be handled there.
If you have ideas for improvement of this library (or its documentation) let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants