Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the auth window to the top when the tab is reopened #62

Open
Steve0Greatness opened this issue Jan 18, 2024 · 4 comments
Open

Bring the auth window to the top when the tab is reopened #62

Steve0Greatness opened this issue Jan 18, 2024 · 4 comments

Comments

@Steve0Greatness
Copy link
Contributor

One issue I frequently see people having in Scratch Auth's help topic is that the auth page "closes" when they paste their code into their profile(or the auth project). I'm pretty sure it's possible to do this using the focus() method on Window objects in JavaScript, but I haven't been able to get this working consistently myself.

Another solution would be to add a dialog box that shows the user how to reopen the auth window.

@RedMan13
Copy link
Contributor

you can make the browser focus on a window?

@RedMan13
Copy link
Contributor

also, the other solution is to just open a tab instead of a popup since you can get the same window object to work with

@Steve0Greatness
Copy link
Contributor Author

Steve0Greatness commented Feb 4, 2024

also, the other solution is to just open a tab instead of a popup since you can get the same window object to work with

Alright then. I've made a branch on my fork of this repo that does this(available at Steve0Greatness/PenguinMod-Home:open-auth-new-tab). I could make a PR if you think this is the best way to address this issue.

@Ianyourgod
Copy link
Member

this needs to be implemented for the new login method. ill try to do it after the server is put back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants