Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters error on CLI #5

Open
Peekmo opened this issue Sep 16, 2014 · 5 comments
Open

Filters error on CLI #5

Peekmo opened this issue Sep 16, 2014 · 5 comments
Labels

Comments

@Peekmo
Copy link
Owner

Peekmo commented Sep 16, 2014

Hello

There's problems on the use of filters with PHP CLI (@see unit test testGetAllByKeyFiltered), the eval function seems to fail. If someone got an idea..

Regards,
Peekmo

@Peekmo Peekmo added the bug label Sep 16, 2014
@polerin
Copy link

polerin commented Dec 5, 2014

I'll see if I can clear this. I need CLI to work ;)

@Peekmo
Copy link
Owner Author

Peekmo commented Dec 5, 2014

Il could be nice, that's really annoying, also for unit tests.. I spend many many hours on it.. never found the problem.

@polerin
Copy link

polerin commented Dec 5, 2014

Looks like it's in how tempFilters() parses the dot notation. I don't have it fixed yet, but I have made a little progess on it.

@polerin
Copy link

polerin commented Dec 5, 2014

What I've done so far, I'll dig into it a bit more this weekend probably, but if you have any ideas or direction please let me know
https://github.com/polerin/JsonPath/compare/FilterFix?diff=split&name=FilterFix

@fadoe
Copy link

fadoe commented Mar 18, 2015

The problem is the syntax on line 233. the right one should be:
$res = eval('$name = $expr;');
But then your test has a endless loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants