Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by curation status does not work #114

Open
arteymix opened this issue Oct 30, 2024 · 4 comments
Open

Sorting by curation status does not work #114

arteymix opened this issue Oct 30, 2024 · 4 comments
Labels

Comments

@arteymix
Copy link
Member

Either disable this or describe how the sorting should work and I'll try to implement the necessary backend features.

@arteymix arteymix added the bug label Oct 30, 2024
@oganm
Copy link
Member

oganm commented Oct 31, 2024

it currently works by sorting by needsAttention. Ideally we would be sorting by the curation note, probably alphabetically

@arteymix
Copy link
Member Author

arteymix commented Nov 1, 2024

I think what confused me is that the icon was not consistently appearing for the top results.

As an alternative, we could sort by the date of the needs attention event.

@oganm
Copy link
Member

oganm commented Nov 2, 2024

the icon still won't always appear in the top results with that though. not all needsAttention = true dataset has a note

@arteymix
Copy link
Member Author

arteymix commented Nov 2, 2024

Oh, I see. In that case we should always show an icon for datasets that need attention and use the note as title if present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants