Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui-router legacy import #239

Open
bernardocs opened this issue Sep 4, 2017 · 1 comment
Open

Update ui-router legacy import #239

bernardocs opened this issue Sep 4, 2017 · 1 comment

Comments

@bernardocs
Copy link
Contributor

Hey guys!

It came to my attention (way back, actually) that the import done on the generator/component/temp.js file, which serve as scaffold to generate new components, is using a outdated module name.

Refer to this: angular-ui/ui-router/CHANGELOG.md

For the sake of keeping the project updated, changing it from:

import uiRouter from 'angular-ui-router';

to

import uiRouter from '@uirouter/angularjs';

would be right.

The reason I'm opening a issue for it, instead of a PR, is to discuss the impact of this change before going for it.

@samithaf
Copy link
Contributor

Hey @bernardocs I am using ui.router version 1.0.8 in a large scale application ( more than 100K LOC ) and from my experience I can say that latest ui.router is very powerful but documentation is bit weak. Other than that it's wise decision to update the project to use latest version of ui.router

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants