Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Papirus to KDE Plasma 6 #3663

Open
5 of 6 tasks
lhy7889678 opened this issue Mar 7, 2024 · 124 comments
Open
5 of 6 tasks

Adapt Papirus to KDE Plasma 6 #3663

lhy7889678 opened this issue Mar 7, 2024 · 124 comments

Comments

@lhy7889678
Copy link

lhy7889678 commented Mar 7, 2024


A MESSAGE FROM MAINTAINERS:

THIS ISSUE COLLECTS ALL KNOWN ISSUES WITH KDE PLASMA 6 WHEN THE PAPIRUS ICON THEME IS APPLIED

BEFORE REPORTING A NEW PROBLEM OR BUG, PLEASE CHECK IF THE PROBLEM IS STILL PRESENT WHEN USING THE LATEST PAPIRUS GIT MASTER

FOR USEFUL BACKGROUND REGARDING SYMBOLIC ICONS IN PLASMA 6, SEE #3595

PLEASE UNDERSTAND THAT PAPIRUS ICON THEME HAD ALREADY INCLUDED SYMBOLIC ICONS PRIOR TO THE PLASMA 6 RELEASE AND THOSE ICONS NOW SHOW UP IN PLASMA AS UNTHEMEABLE, APPEARING EITHER WHITE OR DARK GREY DEPENDING ON THE APPLIED PAPIRUS VERSION

FEEL FREE TO REPORT SUCH ICONS, BUT ACKNOWLEDGE THAT THIS IS SOMETHING THAT CAN ONLY BE FIXED WITH RESTRUCTURING WITHIN PAPIRUS

ORIGINAL MESSAGE INCLUDED BELOW


KDE Plasma 6 seems to have changed the names of some icons used in the system tray / system settings / etc. As a result, these icons will fall back to the default Breeze icon theme, even though Papirus has adequate icons (with different names) for them.

Here is a list of icons that I have noticed so far:

  • brightness-high-symbolic, redshift-status-off-symbolic, redshift-status-on-symbolic, redshift-status-day-symbolic: Used in the brightness controller
  • klipper-symbolic: Used in the clipboard manager
  • notifications-disabled-symbolic, notification-active-symbolic, notification-inactive-symbolic: Used in the notification manager
  • kdeconnect-tray-symbolic: Used by KDE Connect

(everything above could also have their counterparts without "-symbolic")

Note that this is not an exhaustive list. Maybe we can refer to the new Breeze icon theme repository to find what's not included in Papirus.

@Bingo90
Copy link

Bingo90 commented Mar 7, 2024

The removable devices tray icon also shows a colored version, not a monochrome version - not sure this is intended
grafik

@stengun
Copy link

stengun commented Mar 7, 2024

Relevant post from Nate:
https://pointieststick.com/2023/08/12/how-all-this-icon-stuff-is-going-to-work-in-plasma-6/

@d-avery
Copy link

d-avery commented Mar 7, 2024

I was about to make this same issue! Papirus is my favorite icon pack. Looking forward to using it with Plasma 6!

@monstorix
Copy link
Contributor

Panel related adaptions was once mentioned by #3595.

@archisman-panigrahi
Copy link

archisman-panigrahi commented Mar 8, 2024

Plasma 5
Screenshot_20240307_225216b
Plasma 6 (please ignore the annotation around the battery. Also the power icon changing to Plasma icon is a bug with that applet, it is not a Plasma issue.)
Screenshot_20240308_113036

@dmaliog
Copy link

dmaliog commented Mar 10, 2024

I support we are waiting for Plasma 6! Papirus is the best set!

@morganist
Copy link
Contributor

morganist commented Mar 15, 2024

do we make the symbolic klipper icon to be a generic metal clip icon ( clipboard ) used for clipman in xfce, for example? or perhaps a better solution would be to draw a new icon that would be more similar to the one breeze icon theme uses? ( klipper-symbolic )
also, we have a few klipper icons in various old plasma themes. those could be used too.

morganist added a commit that referenced this issue Mar 15, 2024
@morganist
Copy link
Contributor

Okay guys, I don't think it is possible to have a solution right now. KDE colour scheme icons currently only have sizes up to 24px in Papirus, but the ones that were previously used inside the Plasma themes need to have 32px and 22px sizes. There's no place for symbolic 32px icons at the moment. And even after figuring out where to put them, the necessary scripts for preparing and converting the icons need to be modified. I managed to assemble a quick-and-dirty solution, but I think it is better not to merge it. We need restructuring. I guess I can finally understand what @SmartFinn meant by his harsh reaction to this change in Plasma 6.

@morganist
Copy link
Contributor

I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere, but I'm not experienced in the project structure and script writing, so I'll be waiting for Serhii to say his word.

@monstorix
Copy link
Contributor

I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere

It looks like KDE has done something similar to Breeze Icons 6. In one of Nate Graham's blog posts he said that Plasma 6 will adapt to the way GNOME uses the -symbolic suffix, which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones.

@morganist
Copy link
Contributor

morganist commented Mar 15, 2024

which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones.

@monstorix we could, but as I've said we need some non-trivial restructuring. The situation is dire because symbolic icons which are used in GNOME don't adapt their colour, but the icons with the KDE colourscheme support do. And now they are mixed up. I haven't given it much thought, but it seems like another challenge.

@SmartFinn
Copy link
Member

SmartFinn commented Mar 15, 2024

Sorry, I don't have enough time to install KDE on my laptop to see the changes. I suppose that @monstorix @morganist is right, this is required some major changes to Papirus icon theme. KDE may need 22px, and 24px symbolic icons, that we don't support now.

I wrote a script that converts 16px icons into 22px, and 24px, sometime ago. So it shouldn't be a problem. However, we should find the right icon theme structure at first. Another way is creating a fork for Plasma 6.

@monstorix
Copy link
Contributor

Another thing that may affect the works:
KDE VDG team is currently in the process of fully migrating (redrawing) the 22px Breeze icons to 24px, for better cross-compatibility with GTK size. Which may imply that Plasma will finally settle with 24px for standard monochrome/symbolic icons instead of 22px in current 6.0 version.

@SmartFinn
Copy link
Member

Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray.

@monstorix
Copy link
Contributor

Well, the GTK compatibility saying is also from Nate. It might not pointed to any specific DEs.

@Bingo90
Copy link

Bingo90 commented Mar 18, 2024

Couldn't we just use the icons from the Materia theme? They seem to fit quite well!

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@Bingo90
Copy link

Bingo90 commented Mar 19, 2024

Couldn't we just use the icons from the Materia theme? They seem to fit quite well!
The problem is, every icon in materia plasma 5 theme (in all of them, really) has both 32px and 22px shapes inside the file: small icons are used for the panel and the bigger ones appear when you open the systray widget. Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.

We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@SmartFinn
Copy link
Member

@morganist

As for the 24px icons, I actually wasn't able to find if they are used in any of my installed applications, but they are still in the specification and they are used if the app developer chooses to use them, right?

The 24px actions icons are often using in GTK-based DE, such as Xfce, in toolbars. However, we're talking about symbolic icons that are mostly 16px. 24px symbolic icons are using in elementaryOS, and in Xfce 4 in few places.

@SmartFinn
Copy link
Member

@morganist

Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.

16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it.

@morganist
Copy link
Contributor

morganist commented Mar 19, 2024 via email

@SmartFinn
Copy link
Member

@morganist could you try to add these icons without -symbolic suffix. Maybe it's the right way to add Plasma 6 support to Papirus. Like @hexchain did it in #3606 (comment)

@hazelnot
Copy link

So does this mean Papirus will be incompatible with KDE going forward?

@Covkie
Copy link
Contributor

Covkie commented Oct 10, 2024

image
6.2 Launcher icons

@Tiagoquix
Copy link

@hazelnot I think you can workaround that by forcing Papirus-Light or Papirus-Dark theme instead of the one that is just "Papirus".

@Tiagoquix
Copy link

Tiagoquix commented Oct 10, 2024

image

Needs symlink for update icon in the system tray (Plasma 6.2.0).

Edit: also for the restart screen.

Discover
image

System tray
image

@hazelnot
Copy link

@hazelnot I think you can workaround that by forcing Papirus-Light or Papirus-Dark theme instead of the one that is just "Papirus".

This only works if both the Plasma theme and the application theme are the same, but I'm trying to go with a light application theme and dark Plasma theme

@morganist
Copy link
Contributor

I politely ask everybody to read the disclaimer in the first message of this issue before reporting any new problems with Plasma 6.

@cinnamonbunbuns
Copy link

Small Issue I've noticed even with the latest commit.

The symbolic icons in the Start menu still continue to use a non symbolic icon for the Internet Menu in KDE Plasma 6.2. I've tried manually changing this and nothing seems to happen. I also noticed the Wine Menu didnt have one, however I can submit an icon request if need be for this.
image

@morganist
Copy link
Contributor

morganist commented Oct 12, 2024 via email

@buufmax
Copy link

buufmax commented Oct 12, 2024

Papirus
Screenshot_20241012_183538

Breeze
Screenshot_20241012_183613

Both appears symbolic to me, Papirus it is more bold at least on my taskbar. They looked identical in the scrot.

Checked on

Operating System: openSUSE Tumbleweed 20241011
KDE Plasma Version: 6.2.0
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.3
Graphics Platform: Wayland
---
Papirus (master)

@cinnamonbunbuns
Copy link

cinnamonbunbuns commented Oct 12, 2024

by the way, does anybody have a problem where breeze doesn't use the symbolic icons in the kickoff sidebar (or mixes both), but papirus does?

Yes actually! I noticed this issue last night.

Mine sets symbolic for the internet icon but nothing else
image

@morganist
Copy link
Contributor

morganist commented Oct 12, 2024 via email

@Damglador
Copy link

Damglador commented Oct 19, 2024

@Covkie @cinnamonbunbuns I use "Simple Application Launcher", it has normal icons, and similar to default layout, but you can't add or remove favorites there :( (just in case you'll be interested)

@cinnamonbunbuns
Copy link

@Covkie @cinnamonbunbuns I use "Simple Application Launcher", it has normal icons, and similar to default layout, but you can't add or remove favorites there :( (just in case you'll be interested)

Honestly switched to this and it works for me for now!

@Covkie
Copy link
Contributor

Covkie commented Oct 29, 2024

I mentioned the new 6.2 battery icons earlier but it appears its a bit more convoluted than that: https://github.com/KDE/breeze-icons/blob/master/battery/README.md.

perhaps papirus could adapt this script?

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 2, 2024

KDE made a blog just two hours ago about symbolic icon support for systray, regarding Plasma 6.2.3, https://blogs.kde.org/2024/11/02/this-week-in-plasma-spoooooky-ooooooooom-notifications/

With that said, any progress on the kickoff icons problem?

@morganist
Copy link
Contributor

morganist commented Nov 2, 2024 via email

@Erwin-Iosef
Copy link

The one where kickoff's icons doesn't show the right symbolic icons(which is solved by git version now I believe but still) and it not showing light icons in dark plasma theme when choosing just Papirus in Breeze Twilight, don't know if it's actually a problem on Papirus side though.

@buufmax
Copy link

buufmax commented Nov 5, 2024

Settings & System have same icons on Application Launcher. Papirus (master).

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 5, 2024 via email

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 7, 2024

2024-11-07_13-32
So I worked around it via using the KDE menu editor(Right click application menu -> Edit Applications)

Basically select the category and set it into another icon that looks the same but has another name like"package_something"

2024-11-07-1345

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 7, 2024

Papirus has different versions of the same icon
Except utilities which I had to set into another icon(Nautilus)

Edit: I also worked around the peek at desktop icon being dark to white by moving the appropriate icon from /usr/share/icons/Papirus-Dark/symbolic/places to Papirus's.
Same for the computer icon in "Places" in Application menu.
Hope this helps to anyone reading it.

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 8, 2024

@morganist
image1
image2
The desktop icon and Firefox's default file picker show black in default breeze twilight.

image3
And this.

@morganist
Copy link
Contributor

morganist commented Nov 8, 2024 via email

@Erwin-Iosef
Copy link

Tried it and instantly all the category icons in kicker are back to colour. The only icon that is out of place is the computer(to a lesser extent than Peek at Desktop) and peek at desktop icons I mentioned above with their colour icons.

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 8, 2024

I guess this workaround is more better than my clunky one at the top, except for the desktop and computer icons.
Just need to rename /symbolic/categories to something else and voila.
Thanks! @morganist

I don't know if I should keep the first workaround I mentioned as I don't want to pollute the discussion with junk but admins are free to delete it.

@Erwin-Iosef
Copy link

Erwin-Iosef commented Nov 9, 2024

@morganist I've been wanting to ask about the restructuring that Papirus needed. What most help does Papirus need right now regarding integration into Papirus? I apologise if I bother you but I could use insight. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests