-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Papirus to KDE Plasma 6 #3663
Comments
Relevant post from Nate: |
I was about to make this same issue! Papirus is my favorite icon pack. Looking forward to using it with Plasma 6! |
Panel related adaptions was once mentioned by #3595. |
I support we are waiting for Plasma 6! Papirus is the best set! |
Okay guys, I don't think it is possible to have a solution right now. KDE colour scheme icons currently only have sizes up to 24px in Papirus, but the ones that were previously used inside the Plasma themes need to have 32px and 22px sizes. There's no place for symbolic 32px icons at the moment. And even after figuring out where to put them, the necessary scripts for preparing and converting the icons need to be modified. I managed to assemble a quick-and-dirty solution, but I think it is better not to merge it. We need restructuring. I guess I can finally understand what @SmartFinn meant by his harsh reaction to this change in Plasma 6. |
I could even start adding some necessary 32px symbolic icons myself, perhaps in the apps folder or in a new folder somewhere, but I'm not experienced in the project structure and script writing, so I'll be waiting for Serhii to say his word. |
It looks like KDE has done something similar to Breeze Icons 6. In one of Nate Graham's blog posts he said that Plasma 6 will adapt to the way GNOME uses the -symbolic suffix, which may mean that icon makers can put the symbolic icons in all sizes, alongside the coloured ones. |
@monstorix we could, but as I've said we need some non-trivial restructuring. The situation is dire because symbolic icons which are used in GNOME don't adapt their colour, but the icons with the KDE colourscheme support do. And now they are mixed up. I haven't given it much thought, but it seems like another challenge. |
Sorry, I don't have enough time to install KDE on my laptop to see the changes. I suppose that I wrote a script that converts 16px icons into 22px, and 24px, sometime ago. So it shouldn't be a problem. However, we should find the right icon theme structure at first. Another way is creating a fork for Plasma 6. |
Another thing that may affect the works: |
Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray. |
Well, the GTK compatibility saying is also from Nate. It might not pointed to any specific DEs. |
Couldn't we just use the icons from the Materia theme? They seem to fit quite well! |
Couldn't we just use the icons from the Materia theme? They seem to fit quite well!
The problem is, every icon in materia plasma 5 theme (in all of them, really) has both 32px and 22px shapes inside the file: small icons are used for the panel and the bigger ones appear when you open the systray widget. Papirus has no place for these 32px symbolic icons yet, that's why it's not so simple.
|
We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG |
We'd have to do a lot of it manually, I guess, but for icons that we don't have in Papirus, we could just extract the 22px versions and put them in a separate SVG
That's what i did locally before realising that we need restructuring. I've used plasma theme with materia icons myself.
|
Honestly, I can't remember any place in GTK where 24px icons are used. GNOME uses 16px in menus, buttons, panel, sidebars, and toolbars. 22px is using for appindicators and tray.
@SmartFinn if understand correctly, the KDE developers are talking about compatibility in a broader context — 22px icons aren't present in GTK at all, are they? That's why they want to get rid of them. As for the 24px icons, I actually wasn't able to find if they are used in any of my installed applications, but they are still in the specification and they are used if the app developer chooses to use them, right?
|
The 24px actions icons are often using in GTK-based DE, such as Xfce, in toolbars. However, we're talking about symbolic icons that are mostly 16px. 24px symbolic icons are using in elementaryOS, and in Xfce 4 in few places. |
16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it. |
16px symbolic icons are perfectly scaled to 32px. Rules in index.theme file allow it.
@SmartFinn
Neat, but there's an issue: all of them need to be adapted, because the icons in the symbolic directory lack KDE colour scheme support. For example, there's a pending merge request with symlinks for power profiles in symbolic directiry, but I've tried it and the icons have a different colour on a panel compared to the icons from the panel directory
|
@morganist could you try to add these icons without |
So does this mean Papirus will be incompatible with KDE going forward? |
@hazelnot I think you can workaround that by forcing Papirus-Light or Papirus-Dark theme instead of the one that is just "Papirus". |
This only works if both the Plasma theme and the application theme are the same, but I'm trying to go with a light application theme and dark Plasma theme |
I politely ask everybody to read the disclaimer in the first message of this issue before reporting any new problems with Plasma 6. |
by the way, does anybody have a problem where breeze doesn't use the symbolic icons in the kickoff sidebar (or mixes both), but papirus does?
|
Both appears symbolic to me, Papirus it is more bold at least on my taskbar. They looked identical in the scrot. Checked on
|
@cinnamonbunbuns yeah, it makes working on it even more confusing because plasma devs haven't done much polish on 6.2 release yet
|
@Covkie @cinnamonbunbuns I use "Simple Application Launcher", it has normal icons, and similar to default layout, but you can't add or remove favorites there :( (just in case you'll be interested) |
Honestly switched to this and it works for me for now! |
I mentioned the new 6.2 battery icons earlier but it appears its a bit more convoluted than that: https://github.com/KDE/breeze-icons/blob/master/battery/README.md. perhaps papirus could adapt this script? |
KDE made a blog just two hours ago about symbolic icon support for systray, regarding Plasma 6.2.3, https://blogs.kde.org/2024/11/02/this-week-in-plasma-spoooooky-ooooooooom-notifications/ With that said, any progress on the kickoff icons problem? |
cool, thanks for sharing. it looks like this change doesn't concern Papirus, because all our panel icons are already symbolic by design. And regarding kickoff, what kind of problem are you referring to?
|
The one where kickoff's icons doesn't show the right symbolic icons(which is solved by git version now I believe but still) and it not showing light icons in dark plasma theme when choosing just Papirus in Breeze Twilight, don't know if it's actually a problem on Papirus side though. |
Settings & System have same icons on Application Launcher. Papirus (master). |
Let's see what Plasma 6.2.3 will offer today.
…On Tue, 5 Nov 2024, 12:54 BuuF Max, ***@***.***> wrote:
Settings & System have same
<#3842 (comment)>
icons on Application Launcher. Papirus (master).
—
Reply to this email directly, view it on GitHub
<#3663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFKAXQ6T2LXDDQQOBPK37QDZ7BXDJAVCNFSM6AAAAABEKTIT3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJWGQYTSMJUGU>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
Papirus has different versions of the same icon Edit: I also worked around the peek at desktop icon being dark to white by moving the appropriate icon from /usr/share/icons/Papirus-Dark/symbolic/places to Papirus's. |
@morganist |
yep, those are gnome symbolic icons.
if you are feeling particularly adventurous and don't have a need to use any modern gnome applicarions, you can try installing Papirus in ~/.local/share/icons and just completely deleting the symbolic folder inside the installed icon pack. it's where all these non-recolourable icons are.
|
Tried it and instantly all the category icons in kicker are back to colour. The only icon that is out of place is the computer(to a lesser extent than Peek at Desktop) and peek at desktop icons I mentioned above with their colour icons. |
I guess this workaround is more better than my clunky one at the top, except for the desktop and computer icons. I don't know if I should keep the first workaround I mentioned as I don't want to pollute the discussion with junk but admins are free to delete it. |
@morganist I've been wanting to ask about the restructuring that Papirus needed. What most help does Papirus need right now regarding integration into Papirus? I apologise if I bother you but I could use insight. Thanks. |
A MESSAGE FROM MAINTAINERS:
THIS ISSUE COLLECTS ALL KNOWN ISSUES WITH KDE PLASMA 6 WHEN THE PAPIRUS ICON THEME IS APPLIED
BEFORE REPORTING A NEW PROBLEM OR BUG, PLEASE CHECK IF THE PROBLEM IS STILL PRESENT WHEN USING THE LATEST PAPIRUS GIT MASTER
FOR USEFUL BACKGROUND REGARDING SYMBOLIC ICONS IN PLASMA 6, SEE #3595
PLEASE UNDERSTAND THAT PAPIRUS ICON THEME HAD ALREADY INCLUDED SYMBOLIC ICONS PRIOR TO THE PLASMA 6 RELEASE AND THOSE ICONS NOW SHOW UP IN PLASMA AS UNTHEMEABLE, APPEARING EITHER WHITE OR DARK GREY DEPENDING ON THE APPLIED PAPIRUS VERSION
FEEL FREE TO REPORT SUCH ICONS, BUT ACKNOWLEDGE THAT THIS IS SOMETHING THAT CAN ONLY BE FIXED WITH RESTRUCTURING WITHIN PAPIRUS
ORIGINAL MESSAGE INCLUDED BELOW
KDE Plasma 6 seems to have changed the names of some icons used in the system tray / system settings / etc. As a result, these icons will fall back to the default Breeze icon theme, even though Papirus has adequate icons (with different names) for them.
Here is a list of icons that I have noticed so far:
brightness-high-symbolic
,redshift-status-off-symbolic
,redshift-status-on-symbolic
,redshift-status-day-symbolic
: Used in the brightness controllerklipper-symbolic
: Used in the clipboard managernotifications-disabled-symbolic
,notification-active-symbolic
,notification-inactive-symbolic
: Used in the notification managerkdeconnect-tray-symbolic
: Used by KDE Connect(everything above could also have their counterparts without "-symbolic")
network-flightmode-on
: Used by the network managerinput-touchscreen
: Used by system settingsNote that this is not an exhaustive list. Maybe we can refer to the new Breeze icon theme repository to find what's not included in Papirus.
The text was updated successfully, but these errors were encountered: