Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create title components (h1-h6) #75

Closed
adonyssantos opened this issue Apr 28, 2024 · 3 comments
Closed

Create title components (h1-h6) #75

adonyssantos opened this issue Apr 28, 2024 · 3 comments
Assignees
@ehmenzala
Labels
duplicate This issue or pull request already exists feature New feature or request @palm-tree-css/semantic
Milestone
Palm Tree 2.0.0

Comments

@adonyssantos
Copy link
Member

Add styles to the <h1>, <h2>, <h3>, <h4>, <h5>and <h6> tags.
@adonyssantos adonyssantos added this to the Palm Tree 2.0.0 milestone Apr 28, 2024
@ehmenzala
Copy link
Collaborator 

|-- semantic/
|   |-- src/
|       |-- elements/
|           |-- _headings.scss
|           |-- ...
|-- utilities-class/
|   |-- src/
|       |-- components/
|           |-- _typography.scss
|           |-- ...

I was checking this issue and I found that the headings' styles were already defined in the _typography.scss partial (Inside utilities-class package). This confused me because in the semantic/ package it is a partial called _headings.scss. Where should the headings' styles belong?

@adonyssantos
Copy link
Member Author 

|-- semantic/
|   |-- src/
|       |-- elements/
|           |-- _headings.scss
|           |-- ...
|-- utilities-class/
|   |-- src/
|       |-- components/
|           |-- _typography.scss
|           |-- ...

I was checking this issue and I found that the headings' styles were already defined in the _typography.scss partial (Inside utilities-class package). This confused me because in the semantic/ package it is a partial called _headings.scss. Where should the headings' styles belong?

@ehmenzala this feature should be in the _headings.scss file in the @palm-tree-css/semantic module

@ehmenzala ehmenzala mentioned this issue Apr 29, 2024
Merged
ehmenzala added a commit that referenced this issue Apr 29, 2024
@ehmenzala
feat(frontend): add heading styles (#77)
31756e0 
According to this file structure...

```
|-- semantic/
|   |-- src/
|       |-- elements/
|           |-- _headings.scss
|           |-- ...
|-- utilities-class/
|   |-- src/
|       |-- components/
|           |-- _typography.scss
|           |-- ...
```

I think that styles related to headings in the `_typography.scss`
partial should be removed in order to avoid style duplication (#75).
@adonyssantos adonyssantos added feature New feature or request and removed design system labels May 4, 2024
@adonyssantos
Copy link
Member Author

This will be worked on #92

@adonyssantos adonyssantos added the duplicate This issue or pull request already exists label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehmenzala ehmenzala

Labels
duplicate This issue or pull request already exists feature New feature or request @palm-tree-css/semantic
Projects
None yet
Milestone
Palm Tree 2.0.0
Development

No branches or pull requests
3 participants
@adonyssantos @richardhuaman1 @ehmenzala