Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONPatcherProxy is incombatible with external deep proxies #35

Open
warpech opened this issue Jun 3, 2019 · 0 comments
Open

JSONPatcherProxy is incombatible with external deep proxies #35

warpech opened this issue Jun 3, 2019 · 0 comments
Assignees

Comments

@warpech
Copy link
Contributor

warpech commented Jun 3, 2019

Steps to reproduce

  1. Have an object that has a deep structure
  2. Replace a subbranch in that object with a simple proxied version of that object

Expected result

JSONPatcherProxy should observe changes to that object as usual, i.e. with the same behavior as in the initial object.

Actual result

Some traps are set twice, also the replacement of the proxified object is detected as a replace operation.

I have an idea how to solve it using Symbol instead of Map. I am preparing a fix for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant