New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "oldValue" to a patch #28

Open

dntzhang opened this issue Nov 6, 2018 · 1 comment

dntzhang commented Nov 6, 2018 •

edited

Loading

https://github.com/Tencent/omi

Hope to support oldValue:

{op: "replace", path: "/a/b", value: "aaa2", oldValue: "aaa1"}

If it is convenient, you can review this for omi. I added only one line of code.
https://github.com/Tencent/omi/blob/master/packages/omi/src/proxy.js#L149

The text was updated successfully, but these errors were encountered:

warpech changed the title ~~no issues just thanks~~ Add "oldValue" to a patch

Contributor

warpech commented Mar 25, 2019

Thanks @dntzhang for the kind words. I took the liberty to rename the title to reflect the content of your comment.

oldValue is not part of the JSON Patch standard, but maybe we could either:

implement this as a non-enumerable property
or, add it as a second argument to the observed callback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment