Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport queryparams from URIs/HTTP instead of redefining it #221

Closed
frankier opened this issue Sep 23, 2024 · 0 comments · Fixed by #229
Closed

Reexport queryparams from URIs/HTTP instead of redefining it #221

frankier opened this issue Sep 23, 2024 · 0 comments · Fixed by #229
Assignees

Comments

@frankier
Copy link
Contributor

HTTP.jl already defines queryparams in the URIs.jl namespace. See: https://github.com/JuliaWeb/HTTP.jl/pull/1012/files

HTTP can just re-export this and then there will be no conflict if someone tries to import URIs themselves. Everything will be sorted out by dispatch.

We will need to change the HTTP.jl compat to 1.8. See https://github.com/JuliaWeb/HTTP.jl/blob/master/CHANGELOG.md#v180---2023-04-27

@ndortega ndortega self-assigned this Oct 17, 2024
@ndortega ndortega linked a pull request Oct 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants