Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdba Grouper.get_coordinate after xarray update #2038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix sdba Grouper.get_coordinate after xarray update #2038

wants to merge 1 commit into from

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Uses a dumber way of getting the max doy, that doesn't rely on a private xarray function. There is a public xarray function in >=2024.09, but we still support >=2023.11.

Does this PR introduce a breaking change?

Yes, only if a non-uniform calendar was used with a subset of years that did not include a leap year. The max doy is now static (standard => 366, for example) and not dynamic (standard, 2004 => 366).

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sdba Issues concerning the sdba submodule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adapt_freq broken with 360_day and group 31-doy
1 participant
@aulemahal