Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_setup_logging overrides my settings #185

Open
max-prtsr opened this issue Nov 8, 2024 · 1 comment · May be fixed by #187
Open

_setup_logging overrides my settings #185

max-prtsr opened this issue Nov 8, 2024 · 1 comment · May be fixed by #187

Comments

@max-prtsr
Copy link

def _setup_logging():  # pragma: no cover
    installation.LOGGER.addHandler(logging.StreamHandler())
    installation.LOGGER.setLevel(logging.INFO)

Can we go with

def _setup_logging():  # pragma: no cover
    installation.LOGGER.addHandler(logging.StreamHandler())
    if not installation.LOGGER.level:
        installation.LOGGER.setLevel(logging.INFO)

?

@wesleykendall
Copy link
Member

Yes this sounds good if you want to open a PR

max-prtsr added a commit to max-prtsr/django-pgtrigger that referenced this issue Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants