Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Uncomment flash_loan Bench Once it's Possible to Deploy Custom Solidity Contracts #457

Open
1 task done
0xNeshi opened this issue Dec 16, 2024 · 0 comments
Open
1 task done

[Feature]: Uncomment flash_loan Bench Once it's Possible to Deploy Custom Solidity Contracts #457

0xNeshi opened this issue Dec 16, 2024 · 0 comments
Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: chore A maintenance-related change.

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Dec 16, 2024 •
edited
Loading

What is the feature you would like to see?

See https://github.com/OpenZeppelin/rust-contracts-stylus/pull/407/files#diff-de72526f0bcd113ba994e7528f578c444fb3278fe03cb9b64f8bb346621528e1R59-R60

TODO: uncomment once it's possible to deploy custom Solidity contracts,
or in this case ERC3156FlashBorrowerMock.

We need to update

rust-contracts-stylus/benches/src/lib.rs

Line 47 in 4de08e5

async fn deploy(
to allow deploying custom Solidity contracts, in order to be able to deploy mocks like ERC3156FlashBorrowerMock.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added priority: 0 Nice-to-have. Willing to ship without this. good first issue Good for newcomers. effort: low Easy or tiny task that takes less than a day. type: chore A maintenance-related change. labels Dec 16, 2024
@0xNeshi 0xNeshi mentioned this issue Dec 16, 2024
Open
3 tasks
@0xNeshi 0xNeshi self-assigned this Dec 19, 2024
@0xNeshi 0xNeshi added effort: medium Default level of effort. and removed effort: low Easy or tiny task that takes less than a day. labels Dec 19, 2024
@0xNeshi 0xNeshi removed their assignment Dec 19, 2024
@0xNeshi 0xNeshi changed the title [Feature]: Uncomment flash_loan Bench Once it's Possible to Call ERC-20 from Within sol! Contracts [Feature]: Uncomment flash_loan Bench Once it's Possible to Deploy Custom Solidity Contracts Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Default level of effort. good first issue Good for newcomers. priority: 0 Nice-to-have. Willing to ship without this. type: chore A maintenance-related change.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xNeshi