Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make xcm-simulator mocks match runtimes #371

Open
4meta5 opened this issue Nov 26, 2024 · 1 comment · May be fixed by #372
Open

Make xcm-simulator mocks match runtimes #371

4meta5 opened this issue Nov 26, 2024 · 1 comment · May be fixed by #372
Assignees
@4meta5
Labels
enhancement New feature or request tests integration and unit tests
Milestone
Future Steps

Comments

@4meta5
Copy link
Contributor

4meta5 commented Nov 26, 2024 •
edited
Loading

Follow up issue for #363 raised during its review

  1. use XCM abstractions for all mock configs
  2. add tests to ensure that the XCM config for the mock runtimes match the actual runtime configs exactly
@4meta5 4meta5 added enhancement New feature or request tests integration and unit tests labels Nov 26, 2024
@4meta5 4meta5 self-assigned this Nov 29, 2024
@4meta5 4meta5 added this to the Future Steps milestone Nov 29, 2024
@4meta5 4meta5 moved this from 🗒 Backlog to 🏗 In Development in Substrate Runtime Templates Dec 8, 2024
@4meta5
Copy link
Contributor Author

4meta5 commented Dec 9, 2024 •
edited
Loading

Requires declaring these pallets in xcm_tests::parachain::construct_runtime!:

  • pallet-message-queue
  • cumulus_pallet_xcmp_queue
  • XcmExecutorConfig, xcm_executor::Config
  • cumulus_pallet_xcm
  • pallet_xcm_weight_trader
  • orml_xtokens
  • pallet_xcm_transactor

The pallets listed in the previous comment could be functionally excluded while still using the macros if OpenZeppelin/openzeppelin-pallet-abstractions#15 and OpenZeppelin/openzeppelin-pallet-abstractions#40 were implemented and closed.

However, those issues do not block this one if we just include the pallets listed above. Including them is sensible because the goal of this issue is to better match the actual runtimes when it comes to the XCM configuration.

@4meta5 4meta5 linked a pull request Dec 9, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4meta5 4meta5

Labels
enhancement New feature or request tests integration and unit tests
Projects
Substrate Runtime Templates
Status: 🏗 In Development
Milestone
Future Steps
Development

Successfully merging a pull request may close this issue.

Use abstractions in xcm-simulator mocks OpenZeppelin/polkadot-runtime-templates
1 participant
@4meta5