Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Instead of bundling web3 as a dependency, make it a peerDependency #110

Open
petejkim opened this issue May 15, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@petejkim
Copy link

petejkim commented May 15, 2020

Instead of bundling web3 as a dependency, make it a peerDependency, so that the user of this library can provide a compatible package on their own, instead of having multiple versions of web3 in their project.

Context: I had to use a later version of 1.2.x due to a bug and I had to force the version by using "resolutions" in package.json.

Also, please remove @types/web3 - it's no longer needed as web3 comes with typescript definitions built in.

Thanks for providing this awesome project.

@abcoathup
Copy link
Contributor

Hi @petejkim !

Thanks for the suggestion, it is really appreciated.

The project owner should review your suggestion during the next week.

Please wait until we have discussed this idea before writing any code or submitting a Pull Request, so we can go through the design beforehand. We don’t want you to waste your time!

@abcoathup abcoathup added the enhancement New feature or request label May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants