Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-access: add an indicative header for requests that are made by guest users #4241

Open
peb-adr opened this issue Oct 9, 2024 · 2 comments
Assignees
Labels
enhancement General enhancement which is neither bug nor feature Lorentz projectname needs discussion

Comments

@peb-adr
Copy link
Member

peb-adr commented Oct 9, 2024

Current behavior
Not the following. (lol)

Wanted behavior
The following:

When a user accesses a meeting publicly (i.e. clicks the "public access" button) all following requests should add an http header indicating they are indeed accessing publicly.
Consequently as soon as the users logs in the header should no longer be set.

Additional context
This will make it easier to separate and prioritize requests and take action on that, e.g. route them differently.

@peb-adr peb-adr added the enhancement General enhancement which is neither bug nor feature label Oct 9, 2024
@peb-adr
Copy link
Member Author

peb-adr commented Oct 9, 2024

Name proposal: X-Public-Access: true

@bastianjoel bastianjoel self-assigned this Oct 9, 2024
@MSoeb MSoeb added the Lorentz projectname label Oct 9, 2024
@bastianjoel bastianjoel removed their assignment Oct 9, 2024
@peb-adr peb-adr added the low label Oct 9, 2024
@bastianjoel
Copy link
Member

Status is currently set by a cookie which is sufficient for now. Using a header would have the benefit that we could set this just for api requests and not for requests to client assets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement which is neither bug nor feature Lorentz projectname needs discussion
Projects
None yet
Development

No branches or pull requests

5 participants