Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password reset mail empty #2695

Closed
selyod-ka opened this issue Sep 3, 2024 · 4 comments
Closed

password reset mail empty #2695

selyod-ka opened this issue Sep 3, 2024 · 4 comments
Labels
bug needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Milestone

Comments

@selyod-ka
Copy link

Describe the bug
When using the password reset link on firefox, a mail is sent to the correct mail-address, but the mail is empty.

How to Reproduce

  1. Go to 'https://openslides-domain.tld/login/forget-password
  2. Enter mail-address, press button.
  3. Mail is sent to the address.
  4. The mail is empty; the subject reads as ": "

Expected behavior
The mail should contain a password-reset-link.

System information

  • OpenSlides version: 4.1.14
  • Browser: Firefox
  • Browser version: 129.0.2

Additional context
With Brave (=Chromium 127) the mail sent contains a password reset link.

iiuc, the logs do not contain any useful information and they are the same for both password reset attempts (with firefox and with brave).

docker logs -f
[...]
backendAction-1     | INFO:openslides_backend.shared.handlers.base_handler:Performing action user.forget_password.
auth-1              | 2024-09-03T11:28:01.601Z http://auth:9004: POST -- /internal/auth/create-authorization-token
datastoreWriter-1   | [2024-09-03 11:28:01 +0000] [22] [INFO] Created position 22
datastoreWriter-1   | [2024-09-03 11:28:01 +0000] [22] [INFO] Events executed (1 UPDATE)
datastoreWriter-1   | [2024-09-03 11:28:01 +0000] [22] [INFO] UPDATE: ['user/3']
backendAction-1     | INFO:openslides_backend.shared.handlers.base_handler:Request was successful. Send response now.
[...]
@selyod-ka selyod-ka added the bug label Sep 3, 2024
@selyod-ka
Copy link
Author

i can reproduce the issue in the demo instance.
this is the (redacted: my mail-adress) complete raw mail:

Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from proxy02.example.com ([127.0.0.1])
	by dovecot03.example.com (Dovecot) with LMTP id 41n4OYT51mahRAEAVYRftg
	for <[email protected]>; Tue, 03 Sep 2024 14:05:56 +0200
Received: from proxy02.example.com ([127.0.0.1])
	by proxy02.example.com (Dovecot) with LMTP id kJ5qNbD61mYDCAIAGFAyLg
	; Tue, 03 Sep 2024 14:05:56 +0200
Received: from mailin06.example.com (unknown [10.0.1.6])
	by proxy02.example.com (Postfix) with ESMTPS id 4Wykq83T53z12Q2
	for <[email protected]>; Tue,  3 Sep 2024 14:05:56 +0200 (CEST)
Received: from mx04.example.com (mailin06.example.com [127.0.0.1])
	by mailin06.example.com (Postfix) with ESMTPS id 0DCF321C39
	for <[email protected]>; Tue,  3 Sep 2024 14:05:55 +0200 (CEST)
X-Virus-Scanned: amavisd-new at example.com
X-Spam-Status: v=1; e=base64; a=aes-256-gcm;
 d=hZ9fkOgSUxjfk+gfsuyq3Y3uLbzxprEXFSRSxopMgNv7zOsNPjEmyao8ewrScUBAjiDne9YRF
 TkZHYzdN8TUB3aflZuKKWu0OLnQg6JsLsTh7I+USVvmavBjG06eat3SFevqmdwN8QeWB5/pqgps
 +wd+iF++BAokQ2jv4sI2n43VR9cBxARhZS3Fh66mAZIuWj/k2h041FQIdNavPAo/fSff6WQ/Slv
 T/ikUZejyH+HiABuxO7EOHLwQR6NvzyLbJAOgUDxJEQZ07W/GF1i3w96M9bqL47xZrivi6OC1jr
 qUKAdXtbN6Pk6Yw+2wA+GMKVfhF7rJMbB3RZXOlyF3pxONfjUycihnggxPope0YLCLgyTB8zEnl
 hr/J1aRL5QW+jy/hXcNyHOkI84rhSISyMzd4yspe+y52wDTVdF9uzol4JgNpe/a6DqONf1I94HY
 vuo6qezB9707tL439NZfJ3TT9v6FzxCJ
Authentication-Results: example.com; dmarc=pass (p=none dis=none) header.from=openslides.com
Authentication-Results: example.com; spf=pass smtp.mailfrom=openslides.com
X-TLS-Received-Status: TLSv1.3
Authentication-Results: example.com;
	dkim=pass (2048-bit key) header.d=openslides.com [email protected] header.b=ghgAoc4m;
	dkim-atps=neutral
Received: from mail.openslides.com (mail.openslides.com [136.243.0.249])
	by mx04.example.com (Postfix) with ESMTPS id 4WykpY5wwHzymN
	for <[email protected]>; Tue,  3 Sep 2024 14:05:25 +0200 (CEST)
Received: from [192.168.208.15] (openslides-cloud3.intevation.de [176.9.30.134])
	by mail.openslides.com (Postfix) with ESMTPS id 764518026F
	for <[email protected]>; Tue,  3 Sep 2024 14:05:16 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openslides.com;
	s=201904; t=1725365116;
	bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=;
	h=From:To:Subject:Date:From;
	b=ghgAoc4mCJ2QhgUIEpo7zvj649KXuRhu01Bedzifgl8bZRGqW4UeIDoR5vPZmBC+4
	 lw4euRkX5rAQSlqbsxcniVes5ukJg1a3pI+TKRDyTpy9IuP6g0mFMeAnpONlN9rmOe
	 d1qUJWfAhYn1F/UTJNRZ+JxB0U45QYg7E5Ed0YRW69gR0Flb0XSIpg2DJnbJ7pp7K4
	 ggKRVUYNVUZ4Fr+ET4ItvVcurn66ODCJbeRnjA0cUbuuiAPwFAPhAnl8fIjJhFscjj
	 MwRzFX2m5A3FGDUo9exBe52tWslL/mBfnsw6b5WM8Wqbs9yhsAClEHztjsLMH78WkA
	 ZXZdgfVnORniw==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From: [email protected]
To: [email protected]
Subject: : [email protected]
Date: Tue, 03 Sep 2024 12:05:16 -0000
Message-ID: <[email protected]>

@Elblinator
Copy link
Member

Can you please send the requests from your firefox and brave
The action in the requests should be user.forget_password

@emanuelschuetze emanuelschuetze transferred this issue from OpenSlides/OpenSlides Oct 22, 2024
@emanuelschuetze emanuelschuetze added this to the 4.2 milestone Oct 22, 2024
@selyod-ka
Copy link
Author

sorry, somehow i did not receive any notification on this ticket's update.

i just tested again, with firefox 131 and https://demo.os4.openslides.com
the post-request to https://demo.os4.openslides.com/system/action/handle_request is:
[{"action":"user.forget_password","data":[{"email":"[email protected]"}]}]

the mail i received now contains the username in the subject, but the mail body is still empty.

Return-Path: <[email protected]>
Delivered-To: [email protected]
Received: from proxy02.example.name ([127.0.0.1])
	by dovecot03.example.name (Dovecot) with LMTP id 6gnxMIxtG2dBxQIAVYRftg
	for <[email protected]>; Fri, 25 Oct 2024 12:11:05 +0200
Received: from proxy02.example.com ([127.0.0.1])
	by proxy02.example.name (Dovecot) with LMTP id Et2UM/I+G2e9iAEAGFAyLg
	; Fri, 25 Oct 2024 12:11:05 +0200
Received: from mailin04.example.com (unknown [10.0.0.64])
	by proxy02.example.com (Postfix) with ESMTPS id 4XZdpd5Jq5z125J
	for <[email protected]>; Fri, 25 Oct 2024 12:11:05 +0200 (CEST)
Received: from mx04.example.com (mailin04.example.com [127.0.0.1])
	by mailin04.example.com (Postfix) with ESMTPS id A7A6021E3D
	for <[email protected]>; Fri, 25 Oct 2024 12:11:05 +0200 (CEST)
X-Virus-Scanned: amavisd-new at example.com
 d=CQSKPMLleoBo3Fr3aLJepSGemenrl+FYFCC//BczgauhLule8qfLc09FZYx7MtA5Z8ONzvT9W
 pUQ7KCwHdGUleZqME1axCmM2gHKqiNrmjtpNP33ZK7jGtpmnUNMJg7YCibtqW3pLqXsJmJpzqI3
 h6nk+acmnc39q50LzD8FA/HYUkPvCZzWuC3xyD6qy0QyZ9JFJiOWF4IXjWlFEc17Xvr/LUqhRYS
 Ud+ypQWQ2E10WPWOWIofjAeoQo04vvDthdOWUKxBAKJeF3HVv/PDi3Ga/pGv/rE4MDjBxIYTSSA
 IHNQ+XwW+nUVI4ahhzfYiE9ZVl8Mr1YzLhUGP8PS64p3BiipgEkUTipDqhJBScBKmoh7S7RT7M2
 5NtxMg/2mEBe6bIx3QXDQFahggiEocxoj4pxTQvr2NrOpvGXzuHrZbRWg3xX7zDWo6GMD835qhx
 TDHqo2VQ5AvQhlg/a3TVHDAqdlRULdFq7ziCiD94F3y/EilRnDZjn8w=
Authentication-Results: example.com; dmarc=pass (p=none dis=none) header.from=openslides.com
Authentication-Results: example.com; spf=pass smtp.mailfrom=openslides.com
Authentication-Results: example.com;
	dkim=pass (2048-bit key) header.d=openslides.com [email protected] header.b=tVsdnhXT;
	dkim-atps=neutral
Received: from mail.openslides.com (mail.openslides.com [136.243.0.249])
	by mx04.example.com (Postfix) with ESMTPS id 4XZdpc4mSlz12Lc
	for <[email protected]>; Fri, 25 Oct 2024 12:11:04 +0200 (CEST)
Received: from [172.18.0.10] (openslides-cloud3.intevation.de [176.9.30.134])
	by mail.openslides.com (Postfix) with ESMTPS id 9BDF78044B
	for <[email protected]>; Fri, 25 Oct 2024 12:10:58 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=openslides.com;
	s=201904; t=1729851058;
	bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=;
	h=From:To:Subject:Date:From;
	b=tVsdnhXTb77Ao/uaAgQjw6S3w2fokdOx3abzb0Qr25yldGo/AHKykQXeebE6JG615
	 0vtjdDvTM5VvWbfNSshpQoLavlSEy4CKqgNOUZTCuzwlyvGOaKBH4YlfAVqKFjFIEt
	 LOyhtusfzVz/RcGnMcCH7LcSmH6yhalOE4X4k4LhmHV785PtQCD0FDS2JWAOXsZosr
	 O9YHGFj1aUf+xPjsRE+a54WaeH6A2ZXXVMBu3fFGCxWYm6jYDR6vbkCOUq2msGHFsM
	 XIVITt6MdA4JsVRwe6yadAOmkkRQQU6qz8oHLzgCDVUmKY7ITqYRhsSBgs/sDKctO5
	 uP4nLWXMz9xAA==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From: [email protected]
To: [email protected]
Subject: : testtest9734
Date: Fri, 25 Oct 2024 10:10:58 -0000
Message-ID: <[email protected]>

@Elblinator Elblinator added the needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time label Nov 12, 2024
@MSoeb
Copy link

MSoeb commented Nov 13, 2024

This issue seems to be solved by #2701.

Note: If it still happens in your configuration, please create another issue. I strongly assume, that reason of this issue is the same like in #2697 and the solution in #2701 will also fix this problem.

@MSoeb MSoeb closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Projects
None yet
Development

No branches or pull requests

4 participants