Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SLLOS if all speakers with the structure level are interventions or interposed questions #2163

Closed
jsangmeister opened this issue Jan 30, 2024 · 4 comments
Assignees
Milestone

Comments

@jsangmeister
Copy link
Contributor

Upon speaker.update, if a speaker is updated from anything other than intervention or interposed_question to one of them and no other speaker for the structure level remains with another speech_state, the related SLLOS should be deleted.

@luisa-beerboom
Copy link
Member

Does this also apply for speaker creation/deletion?

i.e. if a speaker is created as an intervention, a SLLoS should not be created and in a normal speaker is deleted, as per #2151 , the structure level should also be deleted if no one has spoken yet and all speakers remaining after that are either interventions or interposed questions

@luisa-beerboom
Copy link
Member

Spoke with @jsangmeister : The answer is "yes"

@luisa-beerboom
Copy link
Member

Not having a structure_level_list_of_speakers for these speakers would effectively mean that they can't have a structure_level associated with them, so no fraction membership shown in the client for the interposed question.
Do we really want this?
If yes, I think the speaker.create and -update should throw an error if the structure_level_id is set.

What do you think about this @jsangmeister ?

@luisa-beerboom
Copy link
Member

Closing because this will be done in the client

@luisa-beerboom luisa-beerboom closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants