Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readding point of order speakers #1892

Closed
bastianjoel opened this issue Sep 5, 2023 · 5 comments · Fixed by #1894
Closed

Support readding point of order speakers #1892

bastianjoel opened this issue Sep 5, 2023 · 5 comments · Fixed by #1894
Assignees
Milestone

Comments

@bastianjoel
Copy link
Member

bastianjoel commented Sep 5, 2023

It should be possible to readd the last speaker even if it is a point of order speaker.

Corresponding client issue: #2715

@bastianjoel bastianjoel added this to the 4.1 milestone Sep 5, 2023
@jsangmeister
Copy link
Contributor

Should it be readded as a PoOS, with the same category etc.?

@reiterl reiterl self-assigned this Sep 5, 2023
@reiterl
Copy link
Member

reiterl commented Sep 5, 2023

The action is list_of_speakers/re_add_last. It has a check for point of order in it, which leads to the ActionException.

@reiterl reiterl removed their assignment Sep 5, 2023
@Elblinator
Copy link
Member

Elblinator commented Sep 5, 2023

It should be readded as a normal contribution, not as a PoO.

@jsangmeister
Copy link
Contributor

The action is list_of_speakers/re_add_last. It has a check for point of order in it, which leads to the ActionException.

Yes, that should be changed so the speaker is readded as a normal speaker.

@jsangmeister
Copy link
Contributor

The behaviour should be the same for PoO and non-PoO speakers: They are moved to the first position of the queue, as normal speakers. This means that for PoOS the PoO related fields must be removed.

@reiterl reiterl linked a pull request Sep 6, 2023 that will close this issue
@reiterl reiterl self-assigned this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants