Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeList not using LIBOPENSHOT_AUDIO_DIR variable provided on command line. #978

Open
SnoopAir opened this issue Nov 22, 2024 · 0 comments

Comments

@SnoopAir
Copy link

The documentation on https://www.openshot.org/en/user-guide/ states to use the variable LIBOPENSHOT_AUDIO_DIR in order to point to the recently build openshot audio library. But the CMakeList is not using it but trying to find it on the system!

cmake -DLIBOPENSHOT_AUDIO_DIR=../../libopenshot-audio/build/dist ..

I'm not sure how to create a "Pull request"... hope to learn that soon.

In the meantime, to fix that issue, line 180 of CMakeLists.txt

find_package(OpenShotAudio 0.3.0...0.3.3 REQUIRED)

should IMHO be modified like this:

find_package(OpenShotAudio 0.3.0...0.3.3 HINTS ${LIBOPENSHOT_AUDIO_DIR} REQUIRED)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant