Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure tool does not warn about minimum sizes on objects with a combined symbol #2083

Open
lpechacek opened this issue Aug 22, 2022 · 0 comments · May be fixed by #2309
Open

Measure tool does not warn about minimum sizes on objects with a combined symbol #2083

lpechacek opened this issue Aug 22, 2022 · 0 comments · May be fixed by #2309

Comments

@lpechacek
Copy link
Member

Steps to reproduce

  1. Create undersized (<0.5 mm²) paved area with a bounding line (501 in Mapper's default symbol set).
  2. Active Measure lengths and areas tool.
  3. Switch the area to symbol Paved area (501.1).

Actual behaviour

The tool does not warn about the small size in step 2. After step 3, it issues the minimum area size warning.

Expected behaviour

The measure tool should warn when the object size is smaller than any of the assigned symbol areas. That is, in the case of combined symbols, it should examine all area settings in the embedded symbols.

Configuration

Mapper Version: master-v20201227.4-200-g0fda53dfd200
Operating System: openSUSE Tumbleweed
lpechacek added a commit to lpechacek/mapper that referenced this issue Aug 22, 2022
@lpechacek
MeasureWidget: Warn about min size in combined symbols
a083701 
Combined symbols may contain areas with a minimum size set, be it other
area symbols or private sub-symbols. This patch makes the measure tool
examine the embedded symbols for minimum size and warn if the object is
smaller than any of the minimum sizes.

Closes OpenOrienteeringGH-2083.
lpechacek added a commit to lpechacek/mapper that referenced this issue Sep 10, 2022
@lpechacek @dl3sdo
MeasureWidget: Warn about min size in combined symbols
2a551a4 
Combined symbols may contain areas with a minimum size set, be it other
area symbols or private sub-symbols. This patch makes the measure tool
examine the embedded symbols for minimum size and warn if the object is
smaller than any of the minimum sizes.

Closes OpenOrienteeringGH-2083.

Co-authored-by: Matthias Kühlewein <[email protected]>
dl3sdo added a commit to dl3sdo/mapper that referenced this issue Dec 26, 2024
@dl3sdo
MeasureWidget: Consider minimum size in combined symbols
0879a21 
Combined symbols may contain areas with a minimum size, either in
area symbols or private sub-symbols.

Closes OpenOrienteeringGH-2083.
@dl3sdo dl3sdo linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider minimum area and length in combined symbols dl3sdo/mapper
1 participant
@lpechacek