Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification failures in OMSimulator not matched by FMPy #1392

Open
casella opened this issue Nov 28, 2024 · 0 comments
Open

Verification failures in OMSimulator not matched by FMPy #1392

casella opened this issue Nov 28, 2024 · 0 comments
Assignees

Comments

@casella
Copy link

casella commented Nov 28, 2024

After #1271, the number of Buildings 11.0.0 tests that pass verification when exported as FMUs and run by OMSimulator has improved dramatically, from about 680 to 1031, see report and plot
immagine.

This is very good but still not up to the results with FMPy, with 1294 models passing verification.

@lochel can you please try to compare the cases that fail verification with OMSimulator but pass with FMPy, and see how to fix them?

The FMUs are exactly the same, as well as the solver (CVODE). So, any difference can only be due to issues with

  • event handling
  • proper set-up of simulation parameters (start time, stop time, tolerance, communication interval, solver used)
  • handling of dense output

Please let me know if you need some help with that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants