Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerance values in strongly coupled systems in SSP are ignored #1328

Open
rruusu opened this issue Oct 30, 2024 · 1 comment
Open

Tolerance values in strongly coupled systems in SSP are ignored #1328

rruusu opened this issue Oct 30, 2024 · 1 comment

Comments

@rruusu
Copy link

rruusu commented Oct 30, 2024

Description

Tolerance values provided in the oms:VariableStepSolver annotation elements in SSP are entirely ignored.

The assumed expected behavior is that unless a tolerance value is provided on the command line, the solver for a strongly coupled system uses the tolerance values that are provided in the SSP annotation elements.

However, unless a command line option is provided, both the absolute and relative tolerance values are overwritten with the default value of 1e-4, instead of using the values from the SystemStructure.ssd document.

Version and OS

  • Version: OMSimulator v2.1.2.post5-gce342b6-mingw-notlm-debug
  • OS: Not relevant
@rruusu
Copy link
Author

rruusu commented Oct 30, 2024

I will push a fix to this to my fork shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant