Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tGenerator: lnInst generation capped at 99 #74

Open
danyill opened this issue Dec 29, 2023 · 1 comment
Open

tGenerator: lnInst generation capped at 99 #74

danyill opened this issue Dec 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@danyill
Copy link
Collaborator

danyill commented Dec 29, 2023

I notice that lnInstGenerator only goes up to 99 but it seems to me that this can be much more.

I think in general we're using other functionality to check for LGOS and LSVS instances, but arguably if the user passes these it could be read from the Services section for LGOS and LSVS supervisions nodes.

/** maximum value for `lnInst` attribute */
const maxLnInst = 99;
const lnInstRange = Array(maxLnInst)
.fill(1)
.map((_, i) => `${i + 1}`);

<xs:simpleType name="tLNInst">
  <xs:restriction base="xs:normalizedString">
  <xs:pattern value="[0-9]{1,12}"/>
  </xs:restriction>
</xs:simpleType>

This is not terribly important but I thought I'd mention it.

@danyill danyill added the enhancement New feature or request label Dec 29, 2023
@JakobVogelsang
Copy link
Contributor

Thank you. Very much right. From what I remember that prefix and ln inst together are limited to 13 chars. That is why I went for two char for the ln inst. But we should rethink that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants