-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some payloads coming from Atomic Red team are marked as "Manual" #46
Some payloads coming from Atomic Red team are marked as "Manual" #46
Comments
On staging we have the correct source: https://testing.obas.staging.filigran.io/admin/payloads?query=cGFnZT0wJnNpemU9MTAwJmZpbHRlckdyb3VwW2ZpbHRlcnNdW10mZmlsdGVyR3JvdXAlNUJtb2RlJTVEPWFuZCZzb3J0cyU1QjAlNUQlNUJwcm9wZXJ0eSU1RD1wYXlsb2FkX25hbWUmdGV4dFNlYXJjaD1TY2hlZHVsZWQlMjBUYXNrJTIwUGVyc2lzdGVuY2UlMjB2aWElMjBFdmVudHZpZXdlci5tc2Mma2V5PXBheWxvYWRz |
Hello @EllynBsc and @jborozco
|
Hi @johanah29 👋 2 solutions here IMO: 👉 Solution 1: Keep the payload with a "deprecated in version XX" flag, i think it's important to state to our user that it's deprecated in the current repo version of Atomic Red Team we're using but it might not be the case in a previous version. 👉 Solution 2: Delete the payload from the database, IMO it's not useful for the user to end up on a payload that does not exist in the atomic red team folder. And we should also specify what version of Atomic red team we're using. => I'd say we go for solution 1 for now, and then if we realize that atomic red team updates a lot and we end up with a ton of payloads deprecated then we can put solution 2 in place. WDYT ? |
@johanah29 @EllynBsc Hello, I would say let's delete the payload to make sure our offer is reflecting functioning payloads. |
Hi @jborozco 👋 Good for me! |
Solution 2: If we delete the payload, the user might end up with a scenario/simulation/atomic test that no longer exists (possibly while it’s still running), leading to unpleasant surprises. Proposals: -> Convert it to a manual payload (removing all links with Atomic Red Team) with a "deprecated" tag? – easier to implement
Technical brainstorm: Collector side
Should we apply this approach to the MITRE ATT&CK collector as well? @helene-nguyen & @flavienSindou |
As discussed during our R&D call, @RomuDeuxfois let's: -in the UI, display the 'deprecated' tag for the payload not existing (nothing to do in DB) TBD in the longer run, a more generic approach for the payloads deprecated |
@isselparra @jborozco @RomuDeuxfois quick recap for the logic of status + sources of our payloads:
|
After looking at the code on the Atomic Red Team collector, one can see that the On testing, we can see that the Payload indicated as On https://filigran.obas.filigran.io/, the Payload indicated as For me, we need to make sure that our data is coherent. I propose a migration that addresses the two problems we have:
This is the result on the UI, note the filter on the status with |
For the longer run, for the payloads depreciation, one approach could be that the Collector at the end of processing all the payloads, provide to the OBAS platform all the updated external IDs and on the OBAS side, based on this list, deprecate the necessary payloads. |
Description
https://filigran.obas.filigran.io/admin/payloads
Should be "community"
The text was updated successfully, but these errors were encountered: