Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add operation or flightrack name on sideview and linearview plot area #2461

Open
ReimarBauer opened this issue Aug 15, 2024 · 5 comments · May be fixed by #2592
Open

add operation or flightrack name on sideview and linearview plot area #2461

ReimarBauer opened this issue Aug 15, 2024 · 5 comments · May be fixed by #2592
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@ReimarBauer
Copy link
Member

Currenly only on topview we write the name of the operation or flightrack

@ReimarBauer ReimarBauer added the enhancement New feature or request label Aug 15, 2024
@ReimarBauer ReimarBauer added this to the 10.0.0 milestone Aug 15, 2024
@ReimarBauer ReimarBauer added the good first issue Good for newcomers label Oct 31, 2024
@Abhisek-exe
Copy link

Hey @ReimarBauer can you please send the file name where the changes need to be done and how can i see the current output and also can you say what should be the expected output, any link or visuals will also work.

@ReimarBauer
Copy link
Member Author

ReimarBauer commented Dec 3, 2024

Hi @Abhisek-exe have a look on the tutorials, e.g. minute 3:20
https://mss.readthedocs.io/en/stable/tutorials/tutorial_msui_views.html

image

We currently add the name to the window title and on the plot for a topview view above the EPSG description but we only add it for the sideview or linearview on the window title. We should add it on the plot for sideview and linearview too. Of course there is no EPSG code but it maybe can be done similiar.

For TopView you can start looking from here https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/mpl_map.py#L152

Probably it can be moved into the https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/mpl_qtwidget.py#L114
There we have already a draw_metadata.

The name can also become added on top of the current title.

@Abhisek-exe
Copy link

Abhisek-exe commented Dec 3, 2024

So In mpl_map.py I see there are two classes that is MapCanvas and SatelliteOverpassPatch out of which MapCanvas is required as of now in that i get there is a function named init in which i have a conditional statement which goes like this.....
Screenshot 2024-12-03 215825

of which i am pretty sure that i get the map's operation_name.

Now lets understand the mpl_qtwidget.py

here in viewplotter class there is a function named draw_metadata which obviously takes title of the plot while i can also see classes for top view linear view and sideview plotter.

So I have some queries:

  1. How do mpl_map.py file gets connected with mpl_widget.py
  2. Now which code i should change or which file should i make to get connected with mpl_map.py ?
  3. And from this two files how we can say or where we can say that top view have operation names and sideview and linear view does not have.

@tkshsbcue
Copy link

@ReimarBauer i would like to take on this issue

@ReimarBauer
Copy link
Member Author

@tkshsbcue this was already taken and a PR send

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants