Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a fligh-track into MSCOlab does not update the versions in the version history automatically #1860

Open
joernu76 opened this issue Aug 8, 2023 · 5 comments · May be fixed by #2585
Assignees
Labels
enhancement New feature or request minor msui
Milestone

Comments

@joernu76
Copy link
Member

joernu76 commented Aug 8, 2023

After importing a flight track, it was not updated to MSColab. Changing a table view longitude coordinate updated then the full plan to the server.

Desired behaviour:
After import, a new version should be generated immediately.

@joernu76 joernu76 added the bug Something isn't working label Aug 8, 2023
@joernu76 joernu76 added this to the 8.1.2 milestone Aug 8, 2023
@ReimarBauer
Copy link
Member

@joernu76 I can't reproduce, I created a devel category and tried there on the devel1 OP.

@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 8, 2023

Please provide more details

Refresh on the version history shows the updates

example_ftml_import.webm

@ReimarBauer ReimarBauer added question Further information is requested msui labels Aug 8, 2023
@joernu76
Copy link
Member Author

joernu76 commented Aug 9, 2023

OK, I had a closer look. The Version Window - in contrast to other View windows - is not automatically updated.
This is surprising and thus not Pythonic. :-)
Manually refreshing helps indeed.
Is there a design reason for this?

@joernu76 joernu76 added enhancement New feature or request minor labels Aug 9, 2023
@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 9, 2023

The default is to look on named versions, you need to toggle to All versions too.

To get this updated it requires to implement a handler which act on 'file-changed' (because any user can update), signal_reload.

It was not implemented because it does make on many edits the table flicker.

When implemented that functionality should be covered by a test too.

@ReimarBauer ReimarBauer removed the bug Something isn't working label Aug 9, 2023
@ReimarBauer ReimarBauer modified the milestones: 8.1.2, 9.0.0 Aug 9, 2023
@ReimarBauer ReimarBauer removed the question Further information is requested label Aug 9, 2023
@ReimarBauer ReimarBauer changed the title Importing a fligh-track into MSCOlab does not create a new version Importing a fligh-track into MSCOlab does not update the versions in the version history automatically Aug 9, 2023
@joernu76
Copy link
Member Author

joernu76 commented Aug 9, 2023

If there is a good reason against this update, no worries. But the current situation is confusing. We updated a file to something veery similar and had the apparently bad idea to have a look into the Version History if the import worked as intented instead of looking at the TableView, which would have worked?
I am not sure how this is a performance problem. In particular if the VersionHistory is not open it should not have an effect?

However, I requalify this as a feature request.

@ReimarBauer ReimarBauer added the ESP-Sprint We do a MSS sprint on EuroSciPy 18.8. in Basel. (candidates should be marked with this) label Aug 9, 2023
@ReimarBauer ReimarBauer removed the ESP-Sprint We do a MSS sprint on EuroSciPy 18.8. in Basel. (candidates should be marked with this) label Feb 15, 2024
@ReimarBauer ReimarBauer modified the milestones: 9.0.0, 10.0.0 Feb 15, 2024
@ReimarBauer ReimarBauer self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor msui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants