Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve a full execution payload in the test mev command #3269

Open
3 tasks
OisinKyne opened this issue Sep 10, 2024 · 1 comment
Open
3 tasks

Retrieve a full execution payload in the test mev command #3269

OisinKyne opened this issue Sep 10, 2024 · 1 comment
Labels
protocol Protocol Team tickets

Comments

@OisinKyne
Copy link
Contributor

OisinKyne commented Sep 10, 2024

🎯 Problem to be solved

We currently get a mev relays health status in the test command. This is certainly more accurate than pinging the URL, which we had been doing originally to infer request duration, but is still not the real hot path when a relay is in use.

🛠️ Proposed solution

If we were to also give the test mev command an optional CL REST API (--beacon-node-endpoints), it would be able to figure out the correct details to ask a relay for a payload for the real time next slot. This would be more representative than hitting the health endpoint. It could probably be implemented as a second test.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Sep 10, 2024
@OisinKyne
Copy link
Contributor Author

@gsora says mev-boost has a testutil for doing something very like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

1 participant