Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass cluster definition or cluster lock file to charon test peers #3240

Open
5 tasks
KaloyanTanev opened this issue Aug 27, 2024 · 0 comments
Open
5 tasks

Comments

@KaloyanTanev
Copy link
Contributor

🎯 Problem to be solved

Currently when we want to test our connection with peers, we require peers' ENRs to be passed as a flag. However, this can be a bit tedious process, especially for non-technical people. We can obtain the peers' ENRs from either the cluster definition or cluster lock files. We should allow to pass one of those as well.

🛠️ Proposed solution

  • Add --cluster-definition-path flag for charon test peers command
  • Add --cluster-lock-path flag for charon test peers command
  • Make require flag not --enrs, but one of the 3 --enrs, --cluster-definition-path or --cluster-lock-path
  • Fetch peers from definition / lock file and use them for the charon test peers command

🧪 Tests

  • Tested by new automated unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants