Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channelier - B2B BPP - compliance check #1429

Open
abhinavv245 opened this issue Feb 12, 2024 · 11 comments
Open

Channelier - B2B BPP - compliance check #1429

abhinavv245 opened this issue Feb 12, 2024 · 11 comments

Comments

@abhinavv245
Copy link
Collaborator

RFQ Seller App

/select

  • why are multiple fulfillment_ids provided for the selected item?

/on_select

  • items/fulfillment_ids does not map to the fulfillments/id

/init

  • items/fulfillment_ids does not map to the fulfillments/id
  • billing name should not be an empty string

/on_init

  • payments/@ondc/org/settlement_window should not be an empty string
  • settlement details of seller app are not required as it is collecting the payment

Flow 4

  • PO Rejection should be done in /on_confirm

Flow 5

/on_select(reject)

  • As it is a business error, NACK is not required, rather provide the context and message and additional error object

/confirm

  • payload is missing

Flow 6

  • similar issues

/select(New RFQ)

  • why is transaction_id being changed for a new RFQ
@abhinavv245
Copy link
Collaborator Author

abhinavv245 commented Mar 4, 2024

All flows

/on_search

  • in items/tags, either of veg or non_veg to be used, value will be 'yes'

/on_init

  • @ondc/org/collected_by_status is not a valid attribute in /payments

/on_confirm

  • order/updated_at should not be same as 'created_at'

/on_status

  • Proforma Invoice to be shared before order is picked up, Invoice to be shared once the order is picked up

Flow 5

  • Incorrect Flow as per context/timestamps - (search,on_search,on_select,select,init,on_init,confirm,on_confirm,on_status)

Cancellation flows to be implemented. Is Prepaid payment implemented? If not, what is the ETA?

@sumit034
Copy link
Contributor

sumit034 commented Mar 6, 2024

Flow 5 - the flow is correct. Basically there are two "select" and two "on_select" because of the rejected RFQ. I think the algorithm takes "on_select" of rejected RFQ and "select" of accepted RFQ and showing this error.

Prepaid Payment ETA - Will complete by Monday (11th March)

@abhinavv245
Copy link
Collaborator Author

@sumit034 select_RFQ "timestamp": "2024-03-04T03:04:32.361Z", on_select_reject "timestamp": "2024-03-04T03:04:32.340Z"

@sumit034
Copy link
Contributor

sumit034 commented Mar 6, 2024

oh. will check

@abhinavv245
Copy link
Collaborator Author

All Flows

/on_search

  • items/0/cancellation_terms/0 must NOT have additional properties (refund_eligible),
  • items/0/cancellation_terms/0/cancellation_fee should have either amount or percentage.

/on_confirm

  • items/locations_ids mismatch from /select (on_status as well)

Note: Buyer cancellation flow is missing, also, when will prepaid payment be enabled?

@sumit034

@sumit034
Copy link
Contributor

currently working and testing the prepaid payment. will send the logs within 1-2 days.

@abhinavv245
Copy link
Collaborator Author

abhinavv245 commented Apr 17, 2024

All Flows

/on_search

  • Do you support 'Self-Pickup'? If not this can be removed from the catalog
  • 'POST-FULFILLMENT' is not currently enabled, can be removed from /payments objects in catalog
  • RET codes to be used in category for serviceability in providers/tags
  • cancellation_terms/amount/currency should be 'INR' and not 'IND'
  • FSSAI_LICENSE_NO is not required at item level
  • providers/locations/country/code must be in a valid 'ISO 3166-1 alpha-3' format e.g. IND, SGP

Seller Cancellation

/on_cancel

  • If the merchant cancels the order, the quoted price must be adjusted, and a refund line item should be included in the breakdown. The same procedure applies in the event of a buyer cancellation, with refunds issued for any applicable charges.
  • payments/params/amount to be updated to updated quote price

Note: Prepaid payment flows to be provided

@sumit034

@abhinavv245
Copy link
Collaborator Author

/on_status

  • /documents (Proforma Invoice) is required before order is picked up for RFQ Flow.
  • invalid attributes in quote/breakup/item - enable,discounted, max_logistics_recovery, recover_amount_without_logistics

Buyer cancellation

/on_cancel

  • In case of buyer cancellation, cancellation/cancelled_by should be bap_id

@sumit034

@tanyamadaan
Copy link
Collaborator

on_status

  • Fulfillment.start.instructions are mandatory when status is Picked-up, for sending pickup proof.
  • Fulfillment.end.instructions are mandatory when status is Delivered, for sending delivery confirmation proof.

cancel

  • cancellation_reason_id should be mapped to BAP cancellation.

Cancellation_terms

  • Kindly test with Rapidor and enable cancellation terms in on_init, confirm and on_confirm for order level cancellation terms.

@sumit034

@abhinavv245
Copy link
Collaborator Author

Non-RFQ Seller App

Flow 1

  • cancellation terms to be provided in on_init, confirm, on_confirm

/on_status

  • Pickup timestamp (fulfillments/start/time/timestamp) is required for fulfillment state - Order-delivered
  • /documents (Invoice) is not required before order is picked up for Non RFQ Flow.

Buyer Cancel

/cancel

  • 012 is not a valid cancellation reason code for Buyer NP, SNP to validate

Seller Cancel

/on_cancel

  • context/version,bpp_uri and bbp_id cannot be empty strings
  • serviceability need to be defined for each provider

Location not serviceable flow is missing, Flow 4 and 5 irrelevant for Non RFQ

@sumit034

@abhinavv245
Copy link
Collaborator Author

  • /cancellation_fee/amount/currency should be INR, not IND (on_init onwards)

/on_status

  • Pickup proof (fulfillments/stops/start/instructions/images) is required once the order is picked-up
  • Delivery proof (fulfillments/stops/end/instructions/images) is required once the order is delivered

Seller Cancel

  • /on_cancel/0/message/order/updated_at should not be same as 'created_at'

@itsRajatkumar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants