Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjunction B2B BPP - compliance check #1370

Open
abhinavv245 opened this issue Jan 15, 2024 · 6 comments
Open

Mjunction B2B BPP - compliance check #1370

abhinavv245 opened this issue Jan 15, 2024 · 6 comments

Comments

@abhinavv245
Copy link
Collaborator

abhinavv245 commented Jan 15, 2024

Flow 1

/on_search

  • Reverse Geocoding for location ID W20222745923425 failed for provider with id '61878758-e03f-4f0d-a5a5-0bf74cd072f7'. Area Code 715151 not matching with 22.572600,88.363900 Lat-Long pair.
  • Reverse Geocoding for location ID W20222745822002 failed for provider with id '61878758-e03f-4f0d-a5a5-0bf74cd072f7'. Area Code 715151 not matching with 22.572600,88.363900 Lat-Long pair.
  • tags.attribute is missing in /items for sending mandatory attributes as per taxonomy

/select

  • For Non-RFQ flow, provider/ttl and BUYER_TERMS are not required

/on_select

  • provider need not have additional properties: descriptor,ttl,creds,tags,categories,offers,fulfillments
  • provider/locations need not have additional properties: gps,address,city,state,country,area_code

/init

  • payments/0 must have required property 'collected_by' (BPP should validate schema)

/on_init

  • payments/0 must have required property '@ondc/org/settlement_basis', '@ondc/org/settlement_window', '@ondc/org/withholding_amount'
  • payments/0/collected_by must be equal to one of the allowed values (BAP,BPP)

/confirm

  • dummy values should be avoided (settlement_details)

/on_confirm

  • start/instructions can be set once the order is 'Packed'

/on_status

  • Transaction ID in payments/params is required when the payment status is 'PAID'
  • Payment status will be 'PAID' once the order is 'Completed' for payment type 'ON-FULFILLMENT'
  • Provide valid values for start and end instructions in /fulfillments (Proof of pickup and delivery)
  • Provide status updates for these fulfillment states as well (Packed,Agent-assigned,Out-for-delivery)

Note : Kindly provide logs for all the flows as per test case scenarios

@abhinavv245 abhinavv245 changed the title Mjunction B2B BAP - compliance check Mjunction B2B BPP - compliance check Jan 16, 2024
@abhinavv245
Copy link
Collaborator Author

Non RFQ with Delivery

Flow 1

/on_search

  • providers/locations/gps Incorrect gps value (minimum of six decimal places are required)
  • any reason why some of the number values are enclosed between both single and double quotes "'12'" (fulfillments/id, etc) - can be avoided
  • Is the prepaid payment flow collected by BPP supported? In case it is not, it should be removed from /payments
  • all the attributes which are mandatory as per the taxonomy should be provided in items.tags
  • provider/tags should be provided (serviceability, seller_terms, seller_id)
  • time_to_ship is missing in 'g2' tag

/select

  • why is comm channel link being sent for Non RFQ Flow

/on_select

  • price is not required in /order/items
  • Delivery charges should be provided in quote/breakup when fulfillment is 'Serviceable'
  • is the quote only valid for 30 seconds (init was called after 30 seconds, how is seller app handling once the quote is not valid)
  • comm channel link need not be returned back in order/tags
  • 'Mjunction Shipping' is not a valid @ondc/org/category (should be type of delivery category)

/on_init

  • bpp_terms are missing in order/tags
  • Buyer Finder Fee amount mismatches from /search

/on_confirm

  • payments/0 must have required property '@ondc/org/settlement_basis', '@ondc/org/settlement_window', '@ondc/org/withholding_amount'
  • payments/0/@ondc/org/buyer_app_finder_fee_amount mismatch from /search

/on_status

  • Transaction ID in payments/params is required when the payment status is 'PAID'
  • item/quantity is not required in quote/breakup
  • Invoice needs to be provided in /documents once the order is picked up and onwards
  • @ondc/org/category and @ondc/org/TAT are not required in /fulfillments

Flow 4

  • similar issues

/on_confirm

  • how is /on_confirm triggered before confirm?
  • order/state 'Rejected' is not a valid enum, order will be 'Cancelled'
  • price/value and item/price/value should be a string
  • all line items in the quote should be provided which were provided earlier in /on_select
  • title cannot change in quote/breakup
  • appropriate error code should be used in the error object

@sdey7961
Copy link

@abhinavv245
/on_search : provider/tags should be provided (serviceability, seller_terms, seller_id)
under provider.tags.serviceability.category, if we support RET1A, RET1B, RET1C means more than one, should we send in comma separated value or as multiple objects

@abhinavv245
Copy link
Collaborator Author

Flow 1

/on_search

  • for domain ONDC:RET1A, why is serviceability construct defined for RET1B? ('RET1A-*' can be defined if you are servicing all categories of domain ONDC:RET1A), same goes for 'category_ids' in /items

/confirm

  • payments/0/@ondc/org/settlement_window must be equal to constant (P7D)
  • payments/0/@ondc/org/withholding_amount must be equal to constant (0.00)

/on_status

  • Proforma invoice is not required for Non-RFQ flow

Flow 4

  • Kindly follow the flow as per test case scenarios (item out of stock error in /on_select)

@sdey7961

@abhinavv245
Copy link
Collaborator Author

Flow 1

/on_search

  • 'cancellable' tag is missing in 'g2' in /items/tags
  • do you support prepaid payment collected by BPP? If not, please remove collected_by (for PRE-FULFILLMENT) in payments
  • why the same category_id has been provided in /items/category_ids ("RET1A-10")

Flow 4

  • similar issues

/on_select (reject)

  • @ondc/org/item_quantity should be updated to the available count, subsequently total unit price should be updated

@sdey7961

@tanya-ondc
Copy link
Contributor

/on_search:

  • providers.location has two duplicate entries.

  • Missing mandatory attributes for item:
    dimension_length
    dimension_breadth
    dimension_height
    dimension_unit
    weight_unit
    material
    warranty
    finish
    fire_resistant
    fire_rating

  • item."location_id": "W20222745923425" - Additional attribute - Not required.

@sdey7961

@tanyamadaan
Copy link
Collaborator

Cancellation flows needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants