Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signcatch B2B Exports (BPP) - compliance check #1369

Open
abhinavv245 opened this issue Jan 15, 2024 · 3 comments
Open

Signcatch B2B Exports (BPP) - compliance check #1369

abhinavv245 opened this issue Jan 15, 2024 · 3 comments

Comments

@abhinavv245
Copy link
Collaborator

abhinavv245 commented Jan 15, 2024

Flow 1

/on_search

  • on_search payload is missing

/select

  • fulfillments must have required properties 'id' and 'type'
  • tag : DELIVERY_TERMS not required in /select
  • provider/ttl is missing (BPP should validate schema)
  • items must have required property 'fulfillment_ids'

/on_select

  • "@ondc/org/category' cannot be an empty string

/init

  • provider/ttl is not required
  • payments/collected_by is missing
  • payments/type mismatch from /search

/on_init

  • payments must have required properties : collected_by, @ondc/org/settlement_basis', @ondc/org/settlement_window', @ondc/org/withholding_amount'

/on_confirm

  • context/timestamp difference between on_confirm and confirm should be within 5 seconds

/on_status

  • payments/params/transaction_id can be provided once the order is completed for payment type 'ON-FULFILLMENT'

Flow 4 & 5

  • similar issues as above

/on_select (Flow 5)

  • Message Id cannot be same for different sets of APIs (multiple on_select calls should have different message id)
  • fulfillments/0 must have required property '@ondc/org/provider_name', '@ondc/org/category', '@ondc/org/TAT', 'state'
@abhinavv245
Copy link
Collaborator Author

Flow 1

/on_search

  • providers/items/quantity/available/count must be integer
  • providers/items/quantity/maximum/count must be integer
  • providers/items/matched must be boolean
  • providers/items/recommended must be boolean
  • providers/locations/city/code should not be an empty string

/on_select

  • context/ttl must be equal to constant (PT30S)
  • is the delivery TAT (@ondc/org/TAT) P1D for exports? (time_to_ship == P2D)

/on-init

  • order/billing/phone cannot be changed by seller app in /on_init

Flow 5 (Terms not acceptable)

  • similar issues as above

/on_select (reject)

  • Delivery terms (INCOTERMS) are required for exports in /fulfillments/tags"
  • Delivery charges should be provided in quote/breakup when fulfillment is 'Serviceable'

/init

  • why is init call initiated for the RFQ that was rejected?

Flow 6 (Item quantity unavailable)

  • similar issues as above

/on_select (rejected)

  • In case of item quantity unavailable, item quantity in quote breakup should be updated to the available quantity"

@SignCatch-NP

@tanyamadaan
Copy link
Collaborator

Flow 1

/on_search

* providers/items/quantity/available/count must be integer

* providers/items/quantity/maximum/count must be integer

* providers/items/matched must be boolean

* providers/items/recommended must be boolean

* providers/locations/city/code should not be an empty string

/on_select

* context/ttl must be equal to constant (PT30S)

* is the delivery TAT (@ondc/org/TAT) P1D for exports? (time_to_ship == P2D)

/on-init

* order/billing/phone cannot be changed by seller app in /on_init

Flow 5 (Terms not acceptable)

* similar issues as above

/on_select (reject)

* Delivery terms (INCOTERMS) are required for exports in /fulfillments/tags"

* Delivery charges should be provided in quote/breakup when fulfillment is 'Serviceable'

/init

* why is init call initiated for the RFQ that was rejected?

Flow 6 (Item quantity unavailable)

* similar issues as above

/on_select (rejected)

* In case of item quantity unavailable, item quantity in quote breakup should be updated to the available quantity"

@SignCatch-NP

@SignCatch-NP Logs were submitted without running log utility. Please submit next iteration with log utility report.

@SignCatch-NP
Copy link
Contributor

In RFQ

/on_select (rejected)

  • In case of item quantity unavailable, item quantity in quote breakup should be updated to the available quantity"

The above point is not valid according to current flows. because in RFQ flow the seller has a right to reject the Quote if he doesn't want to sell that much quantity. as the seller wants to sell less or more than the requested quantity.

  • The log utility report is attached to each flow. and it has issues that are not able to be reflected manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants