Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipyaari(RSF) - compliance check #1268

Closed
RupalSingla opened this issue Oct 31, 2023 · 8 comments
Closed

Shipyaari(RSF) - compliance check #1268

RupalSingla opened this issue Oct 31, 2023 · 8 comments

Comments

@RupalSingla
Copy link

RupalSingla commented Oct 31, 2023

orderbook needs to have atleast 5 orders in the orderbook

Flow-1 Successful Reconcilation

/receiver_recon

  • /message/orderbook/orders/0/payment/params/transaction_status must be equal to constant (PAID)
  • /message/orderbook/orders/0/payment/status must be equal to constant (PAID)
  • Please send logs with with buyer app finder fee that is non zero

/on_receiver_recon

  • Ensure that the value within the context.core_version remains consistent across both APIs.
  • why is the counterparty_recon_status": "04", that is not paid

@prashantpdwivedi

@RupalSingla RupalSingla changed the title Shipyaari(IGM) - compliance check Shipyaari(RSF) - compliance check Oct 31, 2023
@prashantpdwivedi
Copy link
Contributor

@RupalSingla

Made changes as per suggestions
PR LINK: #1291

Kindly review

@prashantpdwivedi
Copy link
Contributor

@RupalSingla @bluecypher
Any update on the latest PR, have made changes as per the suggestion
kindly check and revert, please

@sandeepshahi
Copy link
Member

  • several issues in /receiver_recon; Please test with another NP/RSP
  • counterparty_recon_status can't be "01" in case of correction flow

@prashantpdwivedi

@prashantpdwivedi
Copy link
Contributor

@bluecypher
Updated logs as per review
Pull Request Link-1321

@RupalSingla
Copy link
Author

/receiver_recon
Enum for orderbook.orders.state is incorrect , needs to be Completed.
some fields are having empty value , which are not accepted , pls chk

@prashantpdwivedi

@prashantpdwivedi
Copy link
Contributor

@RupalSingla
Updated logs as per review

Also requesting to mention the fields as the comment it is not properly mention which fields are missing
PR LINK

@aakashkanojiya91299
Copy link

@RupalSingla @bluecypher
PR LINK
Any update on the latest PR, have made changes as per the suggestion
kindly check and revert, please

@sandeepshahi
Copy link
Member

Duplicate issue board; refer #1468 for the recent thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants