Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequelstring (SA: RET10) - Compliance Check #2731

Open
Jagannath-wits opened this issue Nov 5, 2024 · 0 comments
Open

Sequelstring (SA: RET10) - Compliance Check #2731

Jagannath-wits opened this issue Nov 5, 2024 · 0 comments

Comments

@Jagannath-wits
Copy link

Flow 1

search

  • Static terms are not enabled yet

On_search

  • Fulfillment.type "delivery and self-pickup" is now deprecated
  • placeholder images/values should not be provided
  • tags.code accept_bap_terms is not required as static terms are not enabled yet.
  • either locations.time.range will be provided or locations.schedule.times and frequency will be provided
  • variants.descriptor.name should be meaningfull
  • tags.servicability is not captured properly, please refer to contract(servicability is defined for each category(i.e category_id) supported by each provider)
  • either @ondc/org/statutory_reqs_packaged_commodities or @ondc/org/statutory_reqs_prepackaged_food should be provided for each item
  • categories.id of both providers should not be same
  • placeholder fssai code should not be provided

Flow 2

select

  • message/order/fulfillment/end/location—> area code not matching with given gps.

on_init

  • @ondc/org/settlement_basis","@ondc/org/settlement_window" and "@ondc/org/withholding_amount not required if buyer Np collecting the amount.
    @ondc/org/buyer_app_finder_fee_type, @ondc/org/buyer_app_finder_fee_amount

on_status_pending is missing

on_status

  • if tracking is true then trackting object should also be provided in fulfillments.tags

on_status_picked

  • invoice url should be provided and should be accurate and valid.

Flow 3

  • Please provide entire flow till journey completion for each flow

Flow 5 and Flow 6 missing

@Nirdosh3312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant