Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sellersetu (BA: RET10,12,13,14,15,18) - Compliance Check #2607

Open
Jagannath-wits opened this issue Oct 8, 2024 · 10 comments
Open

Sellersetu (BA: RET10,12,13,14,15,18) - Compliance Check #2607

Jagannath-wits opened this issue Oct 8, 2024 · 10 comments

Comments

@Jagannath-wits
Copy link

Sellersetu Buyer App

RET10

Search

  • Static terms are not enabled yet, hence not required for now.

on_search

  • return_window should not be P0D even if the item is not returnable, as it also serves as an IGM window.

on_search_inc

  • Invalid object electronics_attributes should not be provided.
  • available_count cannot be 100 (enum values: 0 for not in stock, 99 for in stock).

RET12

Search

  • Static terms are not enabled yet, hence not required for now.

on_search_inc

  • available_count cannot be 100 (enum values: 0 for not in stock, 99 for in stock).

RET13

Search

  • Static terms are not enabled yet, hence not required for now.

on_search

  • EAN code should be provided for RET13.
  • Valid item.descriptor.code values for each domain:
    • RET 10, 13, 16, 18: EAN
    • RET 12: HSN
    • RET 14, 15: GTIN

RET14

on_search

  • Invalid attribute for item with category IDs: RAM, RAM_unit, CPU, GPU, OS_type, OS_version. The item.attribute.code should be in lowercase as defined in the contract. The buyer app should send a Nack for invalid attributes.
  • Ensure that the utility is run properly as the flows key in the payload should be a string (e.g., flows: "1").

RET15

on_search

  • prvdr0tags/serviceability: The serviceability construct is mandatory in /bpp/providers[0]/tags.
  • bpp/descriptor/accept_bap_terms: accept_bap_terms is not required in bpp/descriptor/tags for now.
  • bpp/descriptor/collect_payment: collect_payment is not required in bpp/descriptor/tags for now.
  • item.descriptor.code should include GTIN as the value.

Final Notes @Chaitanya-Keyal

Please ensure the utility is run properly before submitting, as there are issues with the payload structure and flow keys.

@Chaitanya-Keyal
Copy link
Contributor

Chaitanya-Keyal commented Oct 8, 2024

@Jagannath-wits

The utility was run properly before submitting, we have attached the utility payload and response files as well. It did not raise any of these issues and verified the logs. I've used the keys as mentioned in the examples here.

Also, all the issues mentioned for on_search will be shared with the seller app through catalog rejection.

@Jagannath-wits
Copy link
Author

Jagannath-wits commented Oct 8, 2024

@Jagannath-wits

The utility was run properly before submitting, we have attached the utility payload and response files as well. It did not raise any of these issues and verified the logs. I've used the keys as mentioned in the examples here.

@Chaitanya-Keyal in the utility payload you have provided "flow":1 ; but it should be a string i.e "flow":"1"

@Chaitanya-Keyal
Copy link
Contributor

@Jagannath-wits
The utility was run properly before submitting, we have attached the utility payload and response files as well. It did not raise any of these issues and verified the logs. I've used the keys as mentioned in the examples here.

@Chaitanya-Keyal in the utility payload you have provided "flow":1 ; but it should be a string i.e "flow":"1"

I see, will recheck this.

@sellersetu-hub
Copy link
Contributor

Requesting review here, @Jagannath-wits @sandeepshahi @shivang1131

@sellersetu-hub
Copy link
Contributor

@Jagannath-wits @sandeepshahi @shivang1131 Awaiting review here,

@sandeepshahi
Copy link
Member

@sellersetu-hub, please share the link of latest submitted PR.

@sellersetu-hub
Copy link
Contributor

@sandeepshahi
As mentioned, these issues are similar to what were on RET16, and by sellerside api's.

@sellersetu-hub
Copy link
Contributor

The validation for search are in place as catalog rejection.

@sandeepshahi
Copy link
Member

@sellersetu-hub, have you implemented catalog rejection framework? Please share the logs (flow 7 to 9) if they haven't been submitted yet.

@sellersetu-hub
Copy link
Contributor

Yes, have implemented, will share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants