Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LAN Import Plugin doesn't get built #47

Open
jpo-github-work opened this issue Aug 24, 2022 · 4 comments
Open

The LAN Import Plugin doesn't get built #47

jpo-github-work opened this issue Aug 24, 2022 · 4 comments
Labels

Comments

@jpo-github-work
Copy link
Contributor

jpo-github-work commented Aug 24, 2022

This is the current src/olsrv2/CMakeLists.txt:

# add subdirectories
add_subdirectory(netjsoninfo)
add_subdirectory(olsrv2)
add_subdirectory(olsrv2info)
add_subdirectory(olsrv2_old_lan)
add_subdirectory(olsrv2_l2import)
add_subdirectory(olsrv2_lan)
add_subdirectory(route_modifier)

Is there a reason that lan_import is missing? It's still documented in the Wiki...

@jpo-github-work
Copy link
Contributor Author

See #48 for an obvious fix

@jpo-github-work
Copy link
Contributor Author

jpo-github-work commented Aug 25, 2022

@mathiashro Can you merge this? It cannot create a bug...

@mathiashro mathiashro added the bug label Aug 25, 2022
@mathiashro
Copy link
Contributor

Is there a reason that lan_import is missing? It's still documented in the Wiki...

May be @HRogge has some spare time to answer.

@mathiashro Can you merge this? It cannot create a bug...

Done.

Leaving the case open for some time to gather further comments / community feedback.

@jpo-github-work
Copy link
Contributor Author

jpo-github-work commented Aug 29, 2022

@HRogge @mathiashro
The merged patch is either incorrect or incomplete. It should either be reverted or needs pull request #51 to resolve a duplicated symbol issue. The relevant change is the following rename (+ updates to references):

-static struct oonf_subsystem _import_subsystem = {
+static struct oonf_subsystem _olsrv2_lan_import_subsystem = {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants