New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomUriLiteralParsers & CustomUriLiteralPrefixes should not be static or irreversible #3158

Open

xuzhg opened this issue Dec 27, 2024 · 0 comments

Assignees

Labels

Member

xuzhg commented Dec 27, 2024

CustomUriLiteralPrefixes is a static class. Registering a prefix with it by calling AddCustomLiteralPrefix is irreversible.

There are problems:

It's not friendship for unit testing
It's a global level object lifecycle in the application itself.
It's not per-model, so multiple models share the only one instance.
Currency issue
No DI support

CustomUriLiteralParsers contains static fields to register the Parsers. Same as CustomUriLiteralPrefixes:

There are problems:

It's not friendship for unit testing
It's a global level object lifecycle in the application itself.
It's not per-model, so multiple models share the only one instance.
Currency issue
No DI support

gathogojr assigned xuzhg

gathogojr added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment