Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing documentation on data location #371

Open
mikegerber opened this issue Mar 1, 2024 · 4 comments
Open

Confusing documentation on data location #371

mikegerber opened this issue Mar 1, 2024 · 4 comments

Comments

@mikegerber
Copy link

mikegerber commented Mar 1, 2024

This is more of an UX issue, I suppose. In https://ocr-d.de/en/models#where-is-the-data the docs say:

In Docker though, $XDG_CONFIG_HOME=$XDG_DATA_HOME/ocrd-resources=/usr/local/share/ocrd-resources gets symlinked to /models for easier volume handling (and persistency).

While I was trying to debug OCR-D/ocrd_all#413, I read this and thought it was garbled. It is not, I just didn't comprehend it. I suggest changing it to something more readable, e.g.:

In Docker though, $XDG_CONFIG_HOME (set to $XDG_DATA_HOME/ocrd-resources, which ultimately is /usr/local/share/ocrd-resources) gets symlinked to /models for easier volume handling (and persistency).

@mikegerber
Copy link
Author

Do the $XDG_ variables matter here at all?

@bertsky
Copy link
Collaborator

bertsky commented Mar 1, 2024

Good idea! Would you be willing to submit a PR for this (and similar stumbling points)?

Do the $XDG_ variables matter here at all?

One could of course set XDG_CONFIG_HOME=/models in the Dockerfile, but we really want to allow the user overriding these variables (at runtime or in a derived Dockerfile).

@mikegerber
Copy link
Author

Good idea! Would you be willing to submit a PR for this (and similar stumbling points)?

Will do. The only other thing I encountered so far (besides our METS caching bug) was the permission problem on /models (OCR-D/ocrd_all#413, and, somewhat connected the corresponding error message).

@mikegerber
Copy link
Author

Good idea! Would you be willing to submit a PR for this (and similar stumbling points)?

Will do. The only other thing I encountered so far (besides our METS caching bug) was the permission problem on /models (OCR-D/ocrd_all#413, and, somewhat connected the corresponding error message).

Will do. The only other thing I encountered so far (besides our METS caching bug) was the permission problem on /models (OCR-D/ocrd_all#413, and, somewhat connected the corresponding error message).

(ocrd_tesserocr's docs about the model location also is somewhat hard to understand IMO. I'll try to explain in a new issue there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants