product_dimensions 17.0: RecursionError on installation

[jwaes]

Getting a RecursionError when trying to install this module

Module

product_dimensions

Describe the bug

Unable to install.

File "/home/odoo/src/odoo/odoo/modules/registry.py", line 114, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/home/odoo/src/odoo/odoo/modules/loading.py", line 480, in load_modules
    processed_modules += load_marked_modules(env, graph,
  File "/home/odoo/src/odoo/odoo/modules/loading.py", line 364, in load_marked_modules
    loaded, processed = load_module_graph(
  File "/home/odoo/src/odoo/odoo/modules/loading.py", line 204, in load_module_graph
    registry.setup_models(env.cr)
  File "<decorator-gen-19>", line 2, in setup_models
  File "/home/odoo/src/odoo/odoo/tools/func.py", line 87, in locked
    return func(inst, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/modules/registry.py", line 323, in setup_models
    model._setup_fields()
  File "/home/odoo/src/odoo/odoo/models.py", line 3392, in _setup_fields
    field.setup(self)
  File "/home/odoo/src/odoo/odoo/fields.py", line 531, in setup  
  
  [...]
  
  File "/home/odoo/src/odoo/odoo/fields.py", line 531, in setup
    self.setup_related(model)
  File "/home/odoo/src/odoo/odoo/fields.py", line 610, in setup_related
    field.setup(model.env[model_name])
  File "/home/odoo/src/odoo/odoo/fields.py", line 531, in setup
    self.setup_related(model)
  File "/home/odoo/src/odoo/odoo/fields.py", line 610, in setup_related
    field.setup(model.env[model_name])
  File "/home/odoo/src/odoo/odoo/fields.py", line 531, in setup
    self.setup_related(model)
  File "/home/odoo/src/odoo/odoo/fields.py", line 610, in setup_related
    field.setup(model.env[model_name])
  File "/home/odoo/src/odoo/odoo/api.py", line 534, in __getitem__
    return self.registry[model_name](self, (), ())
RecursionError: maximum recursion depth exceeded

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
    RPC_ERROR

To Reproduce

Affected versions:
17.0 (ping @lethuthao2403)

Steps to reproduce the behavior:

1. install the product_dimensions module

Additional context
dev branch on odoo.sh with latest enterprise code.

[rf-ife]

Hello @jwaes
I couldn't reproduce the issue. I was able to install the module normally on a dev branch in Odoo.sh using the latest enterprise code. Perhaps you tried to install another module, such as 'product_dimensions,' and not the OCA one, 'product_dimension'?

[gdgellatly]

Hmmm, I can see a few things that could cause this. The module itself defines fields like product_length on both the template and the product. But products inherit fields from templates. They really shouldn't be identical. Moreover the compute method refers to product templates, but the inheritance would not require this as product would have inherited the templates methods. It is a bit strangely written this module and while I can't pinpoint an exact cause, my guess is it is somehow related to fields being shared.