Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual issue with "Create Torrent" icon and Disk Space display on Firefox over HTTPS #2816

Open
4 tasks done
lafouine022 opened this issue Dec 5, 2024 · 2 comments
Open
4 tasks done

Comments

@lafouine022
Copy link

lafouine022 commented Dec 5, 2024

Please complete the following tasks.

  • Web browser cache cleared
  • Link provided to install script if applicable
  • Not using broken rtinst install script
  • Web browser, ruTorrent, PHP and OS version provided

Tell us about your environment

Environment:

Browser: Firefox lasted version
Protocol: HTTPS
Other browsers tested: Chrome/Edge (no issue).

Tell us how you installed ruTorrent

V5.1.1

Describe the bug

I’ve noticed a visual problem when using Firefox to access the interface over HTTPS:

The "Create Torrent" icon is not displayed correctly.
The Disk Space section also appears distorted or broken.

These issues do not occur when using other browsers or accessing the interface over HTTP.

Steps to reproduce:

Access the interface using Firefox (latest version) over an HTTPS connection.
Observe the "Add Torrent" icon and the Disk Space section.

Suggestions:
It might be related to resource loading over HTTPS or specific Firefox rendering quirks.

You can post this as an issue on GitHub, and it should provide enough context for the developer to investigate. 😊

Steps to reproduce

No response

Expected behavior

No response

Additional context

In HTTP no problème
In chrome or edge no problème

@lafouine022 lafouine022 changed the title Visual issue with "Add Torrent" icon and Disk Space display on Firefox over HTTPS Visual issue with "Create Torrent" icon and Disk Space display on Firefox over HTTPS Dec 5, 2024
@lafouine022
Copy link
Author

Capture d'écran 2024-12-05 190736

@jevenski
Copy link
Contributor

jevenski commented Dec 16, 2024

Linking to image files might break for various reasons. There are 2 ways we load icons in ruTorrent.

  1. Load a whole set of icons in one image file and apply the same image to different icons as the background image with different offset pixels. The offset value can be tedious to adjust in order to put the icon in the right position. When the size of the icon's containing element changes, the neiboring icon image might show up in the icon.
  2. Load a single file for each icon image, and we'll have make quite a few requests for icon images. This does harm to loading performance.

I would suggest that we convert the icons to base64 strings and include them in the relevant css file, just like I did for the context menu icons: #2812. The css file size will be increased, but the time of http requests will be reduced, and maintenance will be much easier. I think it's a worthu tradeoff.

@stickz I'll get down to it if you approve of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants