History Plugin question

[ranirahn]

I noticed something that I just dont remember has it always been like this?

Status column gets deleted after refresh of the browser. Has it allways been this way? Without refresh every row have Added, Deleted or something else in this column. Dont remember right now what was the last one. Why only this column gets deleted with refresh? Its not a big problem because icon infront of the name also tell me what happened to this file, but just want to know does this work as intended? Or maybe its just me and I have done something with my data that this is missing now.

[ranirahn]

I looked into history_data.dat file and i understand the action is how the status is recorded. Example {s:6:"action";i:1;s:4:"name";... here i see that action have value 1. and here {s:6:"action";i:2;s:4:"name"; action value is 2. In the file ruTorrent/plugins/history/init.js in function plugin.onGetHistory = function(d) i see row like that ...}, item.hash, (item.action==1) ? "Status_Down" : (item.action==2) ? "Status_Completed" : "Status_Error" );... that tells me that if action is 1 the status will be Status_Down. If its 2 then the status is Status_Completed and everything else is Status_Error. The question is. If the data is in file and code should also read it, why is Status get values only when torrents get added, deleted or finished on running ruTorrent? Why does this info does not get used on reload? Is it bug again?

[ranirahn]

I think i found the issue. I replaced this plugin.actionNames = ['', '', '', '']; with this plugin.actionNames = ['', theUILang.Added, theUILang.Finished, theUILang.Deleted]; And then there was at least something in the Status column. And it was Completed status. But that is the veird part. In History plugin Lang file the theUILang.Finished = "Finished"; instead. So this is not where this file gets this value. Only place where I found this theUILang.Finished = "Completed"; was in ruTorrent/lang/en.js file instead. So for some reason the Plugin lang file is not loaded in the beginning like it should be. plugin.loadLang(); in the beginning of the init.js file should do that, but it does not.

[ranirahn]

Very interesting. This only happens when you refresh the browser when you have History tab open. If any other tab is open this does not happen. So this column was empty for me only because I had History TAB selected. I think that is so little bug that I dont even bother to find a fix for this.