Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Error executing txs from frames #497

Open
willyogo opened this issue Oct 29, 2024 · 0 comments
Open

Bug: Error executing txs from frames #497

willyogo opened this issue Oct 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@willyogo
Copy link
Collaborator

Currently, if a user attempts to prompt/execute a tx from a frame, an error occurs and the user is never prompted to connect their wallet or execute the tx.

As a user, I want to be able to connect wallet, switch wallet, and execute txs prompted from frames.

We can use frames.js to expedite adding support for in-frame txs https://framesjs.org/guides/transactions

They recommend using the Transactions starter as a template to build your transaction Frames.

Frames.js library doesn't handle connecting or switching wallet; txs are always created for the connected wallet (https://framesjs.org/guides/transactions).

Instead, we should use privy's Wallet Connector to give users the ability to connect, disconnect, or switch wallets https://www.privy.io/features#connectors-1
https://docs.privy.io/guide/react/wallets/external/

This privy + wagmi lib may even be the best bet? https://github.com/privy-io/wagmi-demo

Users wallet should already be connected to nounspace via privy from when they logged in. We need to give them the ability to switch wallet as well. To start, let's mimic Warpcast's implementation..

image

image

AC:

  1. when a user prompts a tx from a frame, a modal is displayed that includes the domain of the frame, the network, and the connected wallet
  2. If a user clicks Continue, they're prompted to execute the tx in their connected wallet.
  3. If user clicks Change, they're prompted to connect a different wallet via the wallet provider
  4. If a user clicks 'Cancel' the modal is closed
  5. Once a user has executed a transaction, they see a confirmation modal with same copy + functionality as warpcast (Transaction Sent
    Your transaction will confirm shortly. View status)

Frame we can use for debugging: https://warpcast.com/bleu.eth/0x0dc07800
Another frame for testing: https://highlight.xyz/mint/base:0xD094D5D45c06c1581f5f429462eE7cCe72215616?fcframe=tx

@willyogo willyogo added the bug Something isn't working label Oct 29, 2024
@willyogo willyogo added the enhancement New feature or request label Oct 29, 2024
@willyogo willyogo added this to the Extermination milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants