Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scylla] - Expose certain settings over the webserver for Argos setting #182

Open
Tracked by #256
jr1221 opened this issue Sep 11, 2024 · 1 comment
Open
Tracked by #256
Assignees
Labels
backend Development Focused in the Backend

Comments

@jr1221
Copy link
Contributor

jr1221 commented Sep 11, 2024

Description

Some settings should be admin/user facing on Argos. Provide a HTTP post endpoint for each of them with param.

Acceptance Criteria

  • Can toggle SCYLLA_DATA_UPLOAD_DISABLE
  • Can set SCYLLA_SOCKET_DISCARD_PERCENT
  • Can set SCYLLA_BATCH_UPSERT_TIME
  • Can toggle SCYLLA_SATURATE_BATCH

Proposed Solution

Use Atomic* types declared above main() in order to provide the functionality.

Have a POST endpoint for each setting (argos/<setting>/set) using a query or param (idk best) with the relevant Atomic passed in as a extension with a static lifetime. The controller will call load with relaxed ordering.

Change the functions that use these settings to take in an atomic type, and check the Atomic* type at each action. Ensure performance regressions are not major with the Atomic* types by using relaxed ordering on store and load.

Mocks

No response

@jr1221 jr1221 added the backend Development Focused in the Backend label Sep 11, 2024
@jr1221
Copy link
Contributor Author

jr1221 commented Sep 14, 2024

Also add get for each param so the client can query the status.

@bracyw bracyw self-assigned this Sep 16, 2024
@jr1221 jr1221 mentioned this issue Dec 6, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Development Focused in the Backend
Projects
None yet
Development

No branches or pull requests

2 participants