Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#177 graph screen improvements #236

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

somshrivastava
Copy link

@somshrivastava somshrivastava commented Oct 28, 2024

Changes

Arrowing through graph screen values is basically done, there is one issue which is mentioned below in the notes

Time is in standard time, not military time

The sizing of the dropdowns on the graph page have been decreased to look more like mqtt, not sure how small they should be, but it can be made even smaller if needed

Realtime button now works

Notes

I'm having trouble getting the tooltip appear, not sure why the Angular Material tooltip isn't working, will look into it more

Not sure what the last checkbox is about regarding receiving new messages, will ask Reid about it more and get it finished

Test Cases

No test cases.

Screenshots

Screenshot 2024-10-28 at 12 52 22 AM

This is what the sizing of the dropdowns now looks like, slightly smaller

To Do

  • Tooltip that shows milliseconds when hovered over time
  • Need some way to tell we're currently receiving new messages (total message count in mqtt)
  • When it clicks realtime button, make sure to clear the current graph being viewed, it doesn't change, but everything else does

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #177 (issue #)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph Screen Improvements
2 participants