Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests #249

Open
martinju opened this issue Jan 22, 2021 · 0 comments
Open

Restructure tests #249

martinju opened this issue Jan 22, 2021 · 0 comments
Assignees

Comments

@martinju
Copy link
Member

Currently, the tests are complicated, hard to maintain and without a clear structure. I suggest to restructure the entire test base as follows:

  • Basic small functions should be tested for giving correct input and output as currently is the case
  • All other functions should be tested through the exported functions (mainly shapr and explain)

Other notes:

  • For the ctree approach, we should test both the party package and the partykit fallback.
  • Switch to using an example dataset that we either create/simulate and store within our package, we find a new data set that we can store in our package or we might use a dataset from the datasets package that we may not need to add to Suggests and use requireNameSpace for (see Switch test/example dataset #248 )
  • If possible in a simple way, make sure that the tests actually ends up at the intended stop-/warning-message
@martinju martinju moved this to Todo in shapr 1.0.0 Jan 4, 2022
@martinju martinju self-assigned this Jan 15, 2022
@martinju martinju moved this from Todo to Done in shapr 1.0.0 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant