Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove depthcharge MGF prefix bug workaround #387

Open
Lilferrit opened this issue Oct 4, 2024 · 1 comment
Open

Remove depthcharge MGF prefix bug workaround #387

Lilferrit opened this issue Oct 4, 2024 · 1 comment
Labels
enhancement New feature or request
Milestone
Depthcharge v0.4

Comments

@Lilferrit
Copy link
Contributor

Once the prefix index= omission for mgf files bug has been addressed in depthcharge, this workaround in MztabWriter.save can be removed:

if Path(filename).suffix == ".mgf" and idx.isnumeric():
  idx = f"index={idx}"

The unit test test_spectrum_id_mgf will very likely have to be updated as well.
@Lilferrit Lilferrit added the enhancement New feature or request label Oct 4, 2024
@Lilferrit Lilferrit added this to the Depthcharge v0.4 milestone Oct 4, 2024
@Lilferrit
Copy link
Contributor Author

Related to wfondrie/depthcharge#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Depthcharge v0.4
Development

No branches or pull requests
1 participant
@Lilferrit