Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to geometric mean for peptide scores #381

Closed
wsnoble opened this issue Sep 18, 2024 · 0 comments · Fixed by #392
Closed

Switch to geometric mean for peptide scores #381

wsnoble opened this issue Sep 18, 2024 · 0 comments · Fixed by #392
Assignees
@Lilferrit
Labels
enhancement New feature or request

Comments

@wsnoble
Copy link
Contributor

wsnoble commented Sep 18, 2024

For consistency with Casanovo-DB, we should switch Casanovo to use geometric mean rather than arithmetic mean of amino acid scores as the peptide-level score.
@bittremieux bittremieux added the enhancement New feature or request label Sep 18, 2024
@Lilferrit Lilferrit self-assigned this Oct 14, 2024
@Lilferrit Lilferrit linked a pull request Oct 14, 2024 that will close this issue
Switched to Geometric Mean for Peptide Level Scores #392
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilferrit Lilferrit

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switched to Geometric Mean for Peptide Level Scores Noble-Lab/casanovo
3 participants
@bittremieux @Lilferrit @wsnoble