Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate mzTab validation #323

Closed
wsnoble opened this issue Apr 17, 2024 · 8 comments · Fixed by #362
Closed

Automate mzTab validation #323

wsnoble opened this issue Apr 17, 2024 · 8 comments · Fixed by #362
Assignees
Labels
enhancement New feature or request

Comments

@wsnoble
Copy link
Contributor

wsnoble commented Apr 17, 2024

To be sure our mzTab stays compliant, we should incorporate the validator into our github actions. This should be done after resolving issues 322 and 201.

@wsnoble
Copy link
Contributor Author

wsnoble commented Jun 25, 2024

Is this already done?

@bittremieux
Copy link
Collaborator

No.

@Lilferrit
Copy link
Contributor

Unfortunately I couldn't for the life of me find a binary for the jmzTab cli. I also tried cloning the jmzTab repo and building the binary from source, but unfortunately jmzTab has dependencies that seem to be no longer publicly available.

@wsnoble
Copy link
Contributor Author

wsnoble commented Jun 26, 2024

Who wrote it? Can we reach out to the authors to ask about its status?

@Lilferrit
Copy link
Contributor

Lilferrit commented Jun 26, 2024

The jmzTab repo (https://github.com/PRIDE-Utilities/jmzTab) is archived and has been read only for about 2 years now which tells me they don't intend on maintaining jmzTab anymore. I can try to reach out to the original authors and see if they have access to a binary still.

@bittremieux
Copy link
Collaborator

jmzTab indeed doesn't seem supported anymore. I've sent the authors an email to verify this.

Alternatively, the validator Bill pointed to is for jmzTab-M (M = metabolomics), which is a related but different standard format. However, the online validator does have a drop-down to switch between mzTab 2.0 (which is for metabolomics) and mzTab 1.0 (which is what we want).

@Lilferrit could you look into whether the jmzTab-M repository has a built binary that can be used to validate our mzTab files?

@Lilferrit
Copy link
Contributor

Unfortunately the link they have to the binaries is also broken on the jmzTab-M repository. I also wasn't able to successfully build the binary on windows but I have access to an ubuntu machine so I'll try it on there as well.

@bittremieux
Copy link
Collaborator

bittremieux commented Aug 2, 2024

The jar from here seems to work. It isn't advertised anywhere, I just found it through Google, and compiling it myself also didn't work, so the provenance is maybe a bit questionable. But it did correctly complain about the floating point charges in older mzTab outputs and was happy after I fixed that.

java -jar jmzTabValidator-3.0.10-SNAPSHOT.jar -check inFile=sample.mztab

Maybe you can try to set up an mzTab validation workflow with this?

@Lilferrit Lilferrit linked a pull request Aug 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants