From f83bce4c4ec8bff6733c7388f96e0ed22e537b0d Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 00:01:24 +0700 Subject: [PATCH 1/7] Update README.md --- README.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 69134c8..5a631d8 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@

# Note -(The difference between the 2 platforms is huge - Be careful when using) +(The difference between the 2 platforms is huge - Be careful when using)
This lib is for personal use, so if you customize your style or change something, Please fork this library and check the detailed documentation in the original library: - [iOS](https://github.com/muukii/Brightroom) @@ -38,7 +38,7 @@ This lib is for personal use, so if you customize your style or change something | iOS | Android | | :---------------------------------: | :-------------------------------------: | -| ![](resources/tool_ios.png) | ![](resources/tools_android.png) | +| ![](resources/tools_ios.png) | ![](resources/tools_android.png) | ## Requirements @@ -76,15 +76,11 @@ const result = await PhotoEditor.open(Options); [How to create cube data from LUT Image](https://www.notion.so/CoreImage-How-to-create-cube-data-from-LUT-Image-for-CIColorCube-CIColorCubeWithColorSpace-9e554fd418e8463abb25d6232613ac1c) -Regarding LUT, the format of LUT changed from v2. - - - We can download the neutral LUT image from [lutCreator.js](https://sirserch.github.io/lut-creator-js/#). ### [Hald Images](https://3dlutcreator.com/3d-lut-creator---materials-and-luts.html) > Hald is a graphical representation of 3D LUT in a form of a color table which contains all of the color gradations of 3D LUT. If Hald is loaded into editing software and a color correction is applied to it, you can use 3D LUT Creator to convert your Hald into 3D LUT and apply it to a photo or a video in your editor. -(Detailed documentations are available on here)[https://www.notion.so/Creating-your-own-filters-LUT-d1942f2f5bcc44d88481d0a0cc4aacb3#d7bba7a891234ea48f1854b5e555366a] +[Detailed documentations are available on here](https://www.notion.so/Creating-your-own-filters-LUT-d1942f2f5bcc44d88481d0a0cc4aacb3#d7bba7a891234ea48f1854b5e555366a) **IMPORTANT** You have to copy [this folder](https://github.com/baronha/react-native-photo-editor/tree/master/resources/LUTs) and paste in Xcode root folder @@ -94,6 +90,7 @@ You have to copy [this folder](https://github.com/baronha/react-native-photo-edi - [ ] Customize. - [ ] Sync between two platforms. +- [ ] ## Contributing From 626d9d0897d7bfdba4e830000e89643db7ede042 Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 00:02:44 +0700 Subject: [PATCH 2/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5a631d8..af0c670 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@

# Note -(The difference between the 2 platforms is huge - Be careful when using)
+*The difference between the 2 platforms is huge - Be careful when using*
This lib is for personal use, so if you customize your style or change something, Please fork this library and check the detailed documentation in the original library: - [iOS](https://github.com/muukii/Brightroom) From 2cc37f0a000db54ed03b6c43202cae7a10f33835 Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 00:03:05 +0700 Subject: [PATCH 3/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index af0c670..d4d69b9 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,7 @@

# Note -*The difference between the 2 platforms is huge - Be careful when using*
+**The difference between the 2 platforms is huge - Be careful when using**
This lib is for personal use, so if you customize your style or change something, Please fork this library and check the detailed documentation in the original library: - [iOS](https://github.com/muukii/Brightroom) From 85211cf4fbee7235b4d29b0baea8d1740ac7fb27 Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 00:03:22 +0700 Subject: [PATCH 4/7] Update README.md --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index d4d69b9..6aadad3 100644 --- a/README.md +++ b/README.md @@ -7,7 +7,8 @@

# Note -**The difference between the 2 platforms is huge - Be careful when using**
+**The difference between the 2 platforms is huge - Be careful when using** +
This lib is for personal use, so if you customize your style or change something, Please fork this library and check the detailed documentation in the original library: - [iOS](https://github.com/muukii/Brightroom) From 89793bd9329c637b3fca9cdeae2897494362e3f6 Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 00:04:15 +0700 Subject: [PATCH 5/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6aadad3..31d0930 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,7 @@ const result = await PhotoEditor.open(Options); | ![](resources/filters_ios.png) | ![](resources/filters_android.png) | ### Custom Filters(iOS) -## LUT (Hald image) +#### LUT (Hald image) [How to create cube data from LUT Image](https://www.notion.so/CoreImage-How-to-create-cube-data-from-LUT-Image-for-CIColorCube-CIColorCubeWithColorSpace-9e554fd418e8463abb25d6232613ac1c) From 27f1c049fd6e6285e17b7f4419a6cd5e201b13ec Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 00:04:44 +0700 Subject: [PATCH 6/7] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 31d0930..863a6b9 100644 --- a/README.md +++ b/README.md @@ -78,7 +78,7 @@ const result = await PhotoEditor.open(Options); [How to create cube data from LUT Image](https://www.notion.so/CoreImage-How-to-create-cube-data-from-LUT-Image-for-CIColorCube-CIColorCubeWithColorSpace-9e554fd418e8463abb25d6232613ac1c) We can download the neutral LUT image from [lutCreator.js](https://sirserch.github.io/lut-creator-js/#). -### [Hald Images](https://3dlutcreator.com/3d-lut-creator---materials-and-luts.html) +#### [Hald Images](https://3dlutcreator.com/3d-lut-creator---materials-and-luts.html) > Hald is a graphical representation of 3D LUT in a form of a color table which contains all of the color gradations of 3D LUT. If Hald is loaded into editing software and a color correction is applied to it, you can use 3D LUT Creator to convert your Hald into 3D LUT and apply it to a photo or a video in your editor. [Detailed documentations are available on here](https://www.notion.so/Creating-your-own-filters-LUT-d1942f2f5bcc44d88481d0a0cc4aacb3#d7bba7a891234ea48f1854b5e555366a) From de3b5c2c55a99463de1c8d1f1e73028276422c7c Mon Sep 17 00:00:00 2001 From: Baron Ha Date: Tue, 3 Aug 2021 09:05:00 +0700 Subject: [PATCH 7/7] Update README.md --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 863a6b9..c052e26 100644 --- a/README.md +++ b/README.md @@ -91,7 +91,6 @@ You have to copy [this folder](https://github.com/baronha/react-native-photo-edi - [ ] Customize. - [ ] Sync between two platforms. -- [ ] ## Contributing