Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event subscription naming does not use fully-qualified handler type name #3

Open
flakey-bit opened this issue Nov 1, 2017 · 0 comments
Open

Event subscription naming does not use fully-qualified handler type name #3

flakey-bit opened this issue Nov 1, 2017 · 0 comments

Comments

@flakey-bit
Copy link

The implementation of PathFactory::SubscriptionNameFor() currently uses handlerType.Name. It should use .FullName because otherwise an event subscription will get lost if there are two handlers for the same event type which happen to be named the same (but under different namespaces).

Note - this issue affects V3 too - see NimbusAPI/Nimbus#274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flakey-bit